perf: avoid expr copies in replace_rec_fn::apply #4702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rators Right now those constructors result in a copy instead of the desired move. We've measured that expr copying and assignment by itself uses around 10% of total runtime on our workloads. See leanprover#4698 for details.
Those represent ~13% of the time spent in `save_result`, even though `r` is a temporary in all cases but one. See leanprover#4698 for details.
github-actions
bot
added
the
toolchain-available
|
!bench |
|
Here are the benchmark results for commit 59e4228. Benchmark Metric Change
==============================================
+ reduceMatch instructions -2.3% (-608.5 σ)
+ stdlib instructions -1.3% (-497.1 σ) |
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those represent ~13% of the time spent in
save_result,even though
ris a temporary in all cases but one.See #4698 for details.