Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: universe level in .below and .brecOn construction #4651

Merged
merged 2 commits into from
Jul 4, 2024
Merged

fix: universe level in .below and .brecOn construction #4651

merged 2 commits into from
Jul 4, 2024

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Jul 4, 2024 •
edited
Loading

I made a mistake in #4517, fixed here, so about time to add a test.

I wonder if this generic level optimization should be moved into mkLevelMax', but not today.

fixes #4650

@nomeata
fix: universe level in .below and .brecOn construction
d45a2a7 
I made a mistake in #4517, fixed here, so about time to add a test.

I wonder if this generic level optimization should be move into `mkLevelMax'`, but not today.

fixes #4650
@nomeata nomeata added will-merge-soon …unless someone speaks up backport releases/v4.10.0 labels Jul 4, 2024
@nomeata nomeata enabled auto-merge July 4, 2024 18:03
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 4, 2024 18:14 Inactive
@nomeata nomeata added this pull request to the merge queue Jul 4, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 4, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2024-07-04 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2024-07-04 18:22:32)

Merged via the queue into master with commit 5ad5c2c Jul 4, 2024
13 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 4, 2024
@nomeata @github-actions
fix: universe level in .below and .brecOn construction (#4651)
76c1698 
I made a mistake in #4517, fixed here, so about time to add a test.

I wonder if this generic level optimization should be moved into
`mkLevelMax'`, but not today.

fixes #4650

(cherry picked from commit 5ad5c2c)
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Merged
nomeata added a commit that referenced this pull request Jul 4, 2024
@github-actions @nomeata
[Backport releases/v4.10.0] fix: universe level in .below and .brecOn…
c24de9d 
… construction (#4653)

Backport 5ad5c2c from #4651.

Co-authored-by: Joachim Breitner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport releases/v4.10.0 toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.below construction fumbles universe levels with reflexive data types
2 participants
@nomeata @leanprover-community-mathlib4-bot