Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: follow simpNF linter's advice #4620

Merged
merged 4 commits into from
Jul 2, 2024
Merged

chore: follow simpNF linter's advice #4620

merged 4 commits into from
Jul 2, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Jul 2, 2024

We can run the simpNF environment linter from Batteries. Nearly all its advice is good.

@kim-em kim-em requested a review from digama0 as a code owner July 2, 2024 03:18
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 2, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 4055aecba25ac7fdca5a2f0de6008c61cc12b51d --onto 4d0b7cf66c140dd83f8c8634293047335a385026. (2024-07-02 03:34:31)

@kim-em kim-em mentioned this pull request Jul 2, 2024
Merged
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 2, 2024 04:00 Inactive
@kim-em kim-em added this pull request to the merge queue Jul 2, 2024
Merged via the queue into master with commit 9cc1164 Jul 2, 2024
13 checks passed
@kim-em kim-em mentioned this pull request Aug 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 24, 2024
@kim-em
chore: running the simpNF linter over Lean (#5133)
07013da 
This should resolve nearly all of the simpNF lints. This is a follow-up
to #4620.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-mathlib4-bot