Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mul recurrence theorems for LeanSAT #4568

Merged
merged 14 commits into from
Jul 2, 2024
Merged

feat: mul recurrence theorems for LeanSAT #4568

merged 14 commits into from
Jul 2, 2024

Conversation

bollu
Copy link
Contributor

@bollu bollu commented Jun 26, 2024 •
edited
Loading

This implements the recurrence theorems getLsb_mul, mulRec_zero_eq, mulRec_succ_eq to allow bitblasting multiplication.

@bollu bollu marked this pull request as ready for review June 26, 2024 20:07
@bollu bollu requested a review from kim-em as a code owner June 26, 2024 20:07
@bollu
Copy link
Contributor Author

bollu commented Jun 26, 2024

The build was failing, but I was surprised as I was rebased on tip-of-tree, and my build succeeded locally, so I can't think of any immediate environment difference between local and remote.

Turns out that I had an unused hypothesis which let me squeeze a proof a little bit.

I would like to turn on warnings as errors locally so I don't accidentally open a PR that fails CI again. How do I do this?

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 26, 2024
@kim-em kim-em added the awaiting-author Waiting for PR author to address issues label Jun 27, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Jun 28, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 18c97926a13bfc82c9266bf00483ab13c6acb64f --onto 62b6e5878981d1bb6d414f21b0c6f8d8a36e6834. (2024-06-28 00:19:20)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 18c97926a13bfc82c9266bf00483ab13c6acb64f --onto bd091f119bc836e91d48c856307a3cfa271225af. (2024-06-28 15:01:00)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 18c97926a13bfc82c9266bf00483ab13c6acb64f --onto 4d0b7cf66c140dd83f8c8634293047335a385026. (2024-07-01 14:06:05)

@kim-em kim-em added awaiting-review Waiting for someone to review the PR awaiting-author Waiting for PR author to address issues and removed awaiting-author Waiting for PR author to address issues awaiting-review Waiting for someone to review the PR labels Jun 28, 2024
@bollu
Copy link
Contributor Author

bollu commented Jun 28, 2024

awaiting-review

@github-actions github-actions bot added awaiting-review Waiting for someone to review the PR and removed awaiting-author Waiting for PR author to address issues labels Jun 28, 2024
@kim-em kim-em removed the awaiting-review Waiting for someone to review the PR label Jul 1, 2024
@kim-em kim-em added this pull request to the merge queue Jul 1, 2024
Merged via the queue into leanprover:master with commit e9d2f8f Jul 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em kim-em left review comments

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bollu @leanprover-community-mathlib4-bot @kim-em