Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lake: non-ident script names #4564

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix: lake: non-ident script names #4564

merged 1 commit into from
Jun 26, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Jun 25, 2024 •
edited
Loading

Fixes a bug where non-identifier script names could not be entered on the CLI without French quotes. Reported on Zulip.

Also adds support for string literal script names in a lakefile.lean.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 25, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 25, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4564
7f5a165
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 25, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4564
eca0ddf
@tydeu tydeu marked this pull request as ready for review June 25, 2024 22:25
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jun 25, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Jun 25, 2024 •
edited
Loading

Mathlib CI status (docs):

@tydeu tydeu added will-merge-soon …unless someone speaks up release-ci Enable all CI checks for a PR, like is done for releases labels Jun 26, 2024
@tydeu tydeu enabled auto-merge June 26, 2024 04:23
@tydeu tydeu added this pull request to the merge queue Jun 26, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 26, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4564
ad6b78f
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 26, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4564
7f74f7e
Merged via the queue into leanprover:master with commit 714dc6d Jun 26, 2024
29 checks passed
@tydeu tydeu deleted the lake/non-ident-script-names branch June 26, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tydeu @leanprover-community-mathlib4-bot