refactor: lake: more robust trace reading #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 20, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 20, 2024
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
tydeu
force-pushed
the
lake/robust-read-trace
branch
from
e1b4279 to
0cf897b
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 21, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 21, 2024
|
@semorrison FYI, this is (IMO) high prio to get into 4.9.0, it fixes a backward compatibility issue which currently afflicts people updating to 4.9.0-rcX from 4.8.0. |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
The recent change of the trace format exposed some unexpected issues with Lake's tracing handling. This aims to fix that. Lake will now perform a rebuild if the trace file is invalid/unreadable. However, it will still fall back to modification times if the trace file is missing. Also, Lake is now backwards compatible with the previous pure numeric traces (and tolerates the absence of a `log` field in the JSON trace). (cherry picked from commit f32780d)
tydeu
added a commit
that referenced
this pull request
Jun 21, 2024
The recent change of the trace format exposed some unexpected issues with Lake's tracing handling. This aims to fix that. Lake will now perform a rebuild if the trace file is invalid/unreadable. However, it will still fall back to modification times if the trace file is missing. Also, Lake is now backwards compatible with the previous pure numeric traces (and tolerates the absence of a `log` field in the JSON trace). (cherry picked from commit f32780d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change of the trace format exposed some unexpected issues with Lake's tracing handling. This aims to fix that.
Lake will now perform a rebuild if the trace file is invalid/unreadable. However, it will still fall back to modification times if the trace file is missing. Also, Lake is now backwards compatible with the previous pure numeric traces (and tolerates the absence of a
logfield in the JSON trace).