Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simp support for OfNat instances that are functions #4481

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix: simp support for OfNat instances that are functions #4481

merged 1 commit into from
Jun 17, 2024

Conversation

leodemoura
Copy link
Member

closes #4462

@leodemoura leodemoura enabled auto-merge June 17, 2024 21:50
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc June 17, 2024 21:55 Inactive
@leodemoura leodemoura added this pull request to the merge queue Jun 17, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 17, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 3c4d6ba8648eb04d90371eb3fdbd114d16949501 --onto 1cf71e54cf268e87cf5c43c830d953f5c88e6c39. (2024-06-17 22:04:00)

Merged via the queue into master with commit fca87da Jun 17, 2024
13 checks passed
@kim-em kim-em mentioned this pull request Jun 20, 2024
Closed
mathlib-bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 20, 2024
@kim-em
chore: adaptations for nightly-2024-06-19 (#13981)
166d0bf 
This contains adaptations for 
* leanprover/lean4#4481
* leanprover/lean4#4497
* leanprover/lean4#4387 (Thanks to @JovanGerb  for these)
* leanprover/lean4#4487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OfNat normalization in simp incorrect when it's overapplied.
2 participants
@leodemoura @leanprover-community-mathlib4-bot