-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: a isDefEq
friendly Fin.sub
#4421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The performance issue at #4413 is due to our `Fin.sub` definition. ``` def sub : Fin n → Fin n → Fin n | ⟨a, h⟩, ⟨b, _⟩ => ⟨(a + (n - b)) % n, mlt h⟩ ``` Thus, the following runs out of stack space ``` example (a : UInt64) : a - 1 = a := rfl ``` at the `isDefEq` test ``` (a.val.val + 18446744073709551615) % 18446744073709551616 =?= a.val.val ``` From the user's perspective, this timeout is unexpected since they are using small numerals, and none of the other `Fin` basic operations (such as `Fin.add` and `Fin.mul`) suffer from this problem. This PR implements an inelegant solution for the performance issue. It redefines `Fin.sub` as ``` def sub : Fin n → Fin n → Fin n | ⟨a, h⟩, ⟨b, _⟩ => ⟨((n - b) + a) % n, mlt h⟩ ``` This approach is unattractive because it relies on the fact that `Nat.add` is defined using recursion on the second argument. The impact on this repo was small, but we want to evaluate the impact on Mathlib. closes #4413
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Jun 11, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 11, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 11, 2024
leanprover-community-mathlib4-bot
added
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
release-ci
Enable all CI checks for a PR, like is done for releases
labels
Jun 11, 2024
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 11, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 11, 2024
It must fail quickly for `n : UInt64`
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 11, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 11, 2024
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 16, 2024
This includes adaptations for: * leanprover/lean4#4430 * leanprover/lean4#4421 * leanprover/lean4#4357 * leanprover/lean4#4385 * leanprover/lean4#4408 Sorry that it's a few days worth in one go, for various reasons it was hard to get to green during this period. --------- Co-authored-by: Johan Commelin <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
This example, reported from LNSym, started failing when we changed the definition of `Fin.sub` in #4421. When we use the new definition, `omega` produces a proof term that the kernel is very slow on. To work around this for now, I've removed `BitVec.toNat_sub` from the `bv_toNat` simp set, and replaced it with `BitVec.toNat_sub'` which uses the old definition for subtraction. This is only a workaround, and I would like to understand why the term chokes the kernel. ``` example (n : Nat) (addr2 addr1 : BitVec 64) (h0 : n ≤ 18446744073709551616) (h1 : addr2 + 18446744073709551615#64 - addr1 ≤ BitVec.ofNat 64 (n - 1)) (h2 : addr2 - addr1 ≤ addr2 + 18446744073709551615#64 - addr1) : n = 18446744073709551616 := by bv_omega ```
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 30, 2024
commit cc6c439bfd5394082369041ddc9e7c428f7a3549 Merge: 15ad26626e5 c1c6ecdf302 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 30 21:31:12 2024 +0000 Merge master into nightly-testing commit 15ad26626e5594da129533a03e1ec590757d318f Merge: 6dc6de87cc2 4e1da241f56 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 30 18:33:23 2024 +0000 Merge master into nightly-testing commit 6dc6de87cc23132ee407aa24f5cb17e39027fd42 Merge: 8bdfc9b12f7 db17c10b93a Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 30 15:31:06 2024 +0000 Merge master into nightly-testing commit 8bdfc9b12f7d39c55cedfa5937676518050d2e31 Merge: 7ac9f0199fd 51ee181d25c Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 30 12:39:05 2024 +0000 Merge master into nightly-testing commit 7ac9f0199fd1d570e2d8d44ea9d5ae473e9433c7 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 30 10:02:45 2024 +0000 chore: bump to nightly-2024-06-30 commit e6bc2290e2825f0e18f3362ebee2ec3a72d01d53 Merge: a84575056d1 7d9b08cda1a Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 30 09:31:31 2024 +0000 Merge master into nightly-testing commit a84575056d1acb904ff06fa8eab32e0e53e012df Author: Kim Morrison <[email protected]> Date: Sun Jun 30 18:43:48 2024 +1000 unusedTactic commit eb26d9a94ad21addb99e516b3525153a59aec3e3 Merge: c017bc8d382 e3eae6f36b1 Author: Kim Morrison <[email protected]> Date: Sun Jun 30 17:13:31 2024 +1000 Merge branch 'nightly-testing' of github.com:leanprover-community/mathlib4 into nightly-testing commit c017bc8d38298f2df8b96d4bdd448375b16d9aaf Author: Kim Morrison <[email protected]> Date: Sun Jun 30 17:13:08 2024 +1000 remove meta if commit e3eae6f36b17d13ac42502012ba85ff2bdecb42e Merge: 42744fcd49b 3415a86bdfb Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 30 06:33:52 2024 +0000 Merge master into nightly-testing commit 42744fcd49be53ad65eca7a1d87c1fdc429e21a8 Author: Kim Morrison <[email protected]> Date: Sun Jun 30 16:03:46 2024 +1000 use new require format, via reservoir commit 1a104692a063533013738d628984fa01ca615650 Merge: 5012478a1e9 0b163fdcb92 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 30 00:45:25 2024 +0000 Merge master into nightly-testing commit 5012478a1e9b84aa5991f81829c01cf67e6cfdd3 Merge: 3d186c3fd78 71e4ce6a107 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 29 21:31:08 2024 +0000 Merge master into nightly-testing commit 3d186c3fd78d36c0e5fa35b272d6845c52362ab4 Merge: 9e1d8311aa5 03cf1129cb3 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 29 18:32:28 2024 +0000 Merge master into nightly-testing commit 9e1d8311aa5f068e8e7c9b27ed1bd3898e464481 Merge: 9f6ab8cd629 79009c6ddde Author: Johan Commelin <[email protected]> Date: Sat Jun 29 19:06:12 2024 +0200 Merge branch 'bump/nightly-2024-06-29' into nightly-testing commit 79009c6ddde5c3e57c0d7f9f0c20c47a96353797 Author: Johan Commelin <[email protected]> Date: Sat Jun 29 19:06:01 2024 +0200 wip commit 9f6ab8cd629f25f840e2ea9687516ad76d18fb9d Merge: 00e92841cc4 f06649a0182 Author: Johan Commelin <[email protected]> Date: Sat Jun 29 18:42:28 2024 +0200 Merge branch 'bump/nightly-2024-06-29' into nightly-testing commit 35de87ff268b1400e7fc7154824df77233f06986 Author: Johan Commelin <[email protected]> Date: Sat Jun 29 18:40:18 2024 +0200 Apply suggestions from code review commit f06649a0182cecf2af81a694f2ac60ace2e17ce6 Author: Johan Commelin <[email protected]> Date: Sat Jun 29 18:37:22 2024 +0200 chore: adaptations for nightly-2024-06-29 commit 00e92841cc4a05d26fb54553f6f2659f14b732be Merge: 9ad4d8372c5 6656396ad8f Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 29 15:31:17 2024 +0000 Merge master into nightly-testing commit 9ad4d8372c5ed80d560c4b1bae5fa600954befa8 Merge: e28b30309e4 9382a75aca1 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 29 12:39:18 2024 +0000 Merge master into nightly-testing commit e28b30309e49f1f9bdf5f690fbe41a84dea2887c Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 29 10:02:54 2024 +0000 chore: bump to nightly-2024-06-29 commit 8fcdf39d8fde53655d7ea58776f7daee0c11734f Merge: ee716e424ec 99d09fff2ed Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 29 09:31:02 2024 +0000 Merge master into nightly-testing commit ee716e424ecfe8ca9cf4da90a34d5a65945531f9 Merge: cc7c97a4afe 0f39e828e15 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 29 00:45:07 2024 +0000 Merge master into nightly-testing commit cc7c97a4afe6ac74c12bcd540602f94c0af800b1 Merge: 3a947eb632e 33d25d9ad4c Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 28 21:31:09 2024 +0000 Merge master into nightly-testing commit 3a947eb632e2bec776ce44a855dada913719d6d0 Merge: 3f59b004fc6 dfc07f1b627 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 28 18:33:25 2024 +0000 Merge master into nightly-testing commit 3f59b004fc60fc84ee4d1dab4c8a441cdb30e2d0 Merge: 07b6551f7b1 c797e3d9f68 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 28 15:31:05 2024 +0000 Merge master into nightly-testing commit 07b6551f7b1ae17ac29d233b55f8b21ac520caa0 Merge: 16ad805429f a41d5a6e440 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 28 12:40:25 2024 +0000 Merge master into nightly-testing commit 16ad805429f3173bc804dbf2a35410ddd8c04778 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 28 10:02:48 2024 +0000 chore: bump to nightly-2024-06-28 commit c42e45074aa68c61f23b12ef515ebe25dc7aff23 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 28 09:30:56 2024 +0000 Merge master into nightly-testing commit 02813177cf8f406cdd1b64b182af27817e796a38 Merge: a2852762dea dcc73cfb2ce Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 28 06:34:25 2024 +0000 Merge master into nightly-testing commit a2852762deafce02d3acc2d07a4133cc52d99467 Author: Kim Morrison <[email protected]> Date: Fri Jun 28 11:27:39 2024 +1000 universes commit 5e580d76c717e9e1a8eb3073c757324764c788f8 Author: Kim Morrison <[email protected]> Date: Fri Jun 28 11:14:54 2024 +1000 fix merge commit ebd4d5b92388ef20c49b9c382effa0921cf09ceb Merge: 807694d9015 c673d9d448c Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 28 00:45:13 2024 +0000 Merge master into nightly-testing commit 807694d90154f4451e43f40d70a6f6f779cd753c Merge: 13605a4fb06 b0640e92cc4 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 27 21:31:27 2024 +0000 Merge master into nightly-testing commit 13605a4fb06571aaaefbf01a2d5d1aa536406c53 Merge: 9d1f3df8d59 b7dc9909e4f Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 27 18:32:52 2024 +0000 Merge master into nightly-testing commit 9d1f3df8d593cd47705a0007d0e0856f607f5575 Merge: 37b2888aad4 e446b83b26b Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 27 15:31:19 2024 +0000 Merge master into nightly-testing commit 37b2888aad4012460d14172ba32c56111f49f5d4 Merge: 70def7340b2 9ab745f86b0 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 27 12:40:32 2024 +0000 Merge master into nightly-testing commit 70def7340b212fb97cae7dfe4ab884b10fae8142 Merge: 79157ac53ee 85543ea7993 Author: Johan Commelin <[email protected]> Date: Thu Jun 27 13:34:46 2024 +0200 Merge branch 'bump/nightly-2024-06-26' into nightly-testing commit 85543ea799315cc2e5f34184382d43bcb9a209d0 Author: Johan Commelin <[email protected]> Date: Thu Jun 27 13:33:30 2024 +0200 chore: adaptations for nightly-2024-06-26 commit 79157ac53ee0eb401b3f83ed9fb22e9c7285cada Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 27 10:02:47 2024 +0000 chore: bump to nightly-2024-06-27 commit 537813e655a02306b6894083ad42816b4153faff Merge: b48f1782f80 9c4c6f78c9a Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 27 09:31:04 2024 +0000 Merge master into nightly-testing commit b48f1782f80768aeb1d25ed8a961fca1b47f4be7 Merge: 612bffa893c 0e9d6a79e2f Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 27 06:34:20 2024 +0000 Merge master into nightly-testing commit 612bffa893ce1a11bd0f9cdf14ec847098499859 Author: Kim Morrison <[email protected]> Date: Thu Jun 27 15:20:21 2024 +1000 fix commit fff3aa2c86fe3cfeeff357eed1ee30aed0b51b2f Author: Kim Morrison <[email protected]> Date: Thu Jun 27 15:17:25 2024 +1000 remove stay set_option commit 13d2f12fa604b33fbb4a9fc6dfaba718c07e775f Author: Kim Morrison <[email protected]> Date: Thu Jun 27 14:59:12 2024 +1000 fix simp says commit 33301e0d473a5e44414ec885db8d56814e1a2de6 Author: Kim Morrison <[email protected]> Date: Thu Jun 27 13:35:16 2024 +1000 close namespace commit da653888d5b1576168a4d7d96136567f469d7498 Merge: 936c6a46b9c 411e6060549 Author: Kim Morrison <[email protected]> Date: Thu Jun 27 13:33:49 2024 +1000 Merge branch 'nightly-testing' of github.com:leanprover-community/mathlib4 into nightly-testing commit 936c6a46b9c3e00a5e8fa5942474fcce827c0641 Author: Kim Morrison <[email protected]> Date: Thu Jun 27 13:33:42 2024 +1000 fixes commit 411e6060549fd856b2d97dd329a672a8b65af221 Merge: 3fd720aa4f5 c95b27fcb89 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 27 03:31:40 2024 +0000 Merge master into nightly-testing commit 3fd720aa4f596f8ba22809ed43abc455b1b3c16a Author: Kim Morrison <[email protected]> Date: Thu Jun 27 13:28:20 2024 +1000 bump aesop commit 371e50405d5fa9ae8960a049452d1f41184fda03 Merge: 241d7d9eaa5 915d8709421 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 27 00:45:04 2024 +0000 Merge master into nightly-testing commit 241d7d9eaa56147994115801e3c45254aad65dbc Merge: 9903a9c96ce cf35070bb02 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 26 18:33:31 2024 +0000 Merge master into nightly-testing commit 9903a9c96ce3d50db6a9a0009de63a788c196d74 Merge: bd6c9f2d385 0c8452ec871 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 26 15:31:08 2024 +0000 Merge master into nightly-testing commit bd6c9f2d38517f581d20a12291f694fc44c47827 Merge: cccdf8b11d0 a1cb4f2c872 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 26 12:41:15 2024 +0000 Merge master into nightly-testing commit cccdf8b11d0e2fd3d49bb063c858aa7f09e3eefd Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 26 10:02:54 2024 +0000 chore: bump to nightly-2024-06-26 commit 4c6161579dff6b346c60c9a94e618de8bd038ab9 Merge: 0ee93a4a5a7 f687f593045 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 26 09:31:22 2024 +0000 Merge master into nightly-testing commit 0ee93a4a5a7c6d0ecbd2e820bc5af53bbe4d3d37 Merge: 173576f0fb8 a98c0321de4 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 26 06:34:44 2024 +0000 Merge master into nightly-testing commit 173576f0fb8ecab8cec32b725b0c94e4156d7171 Merge: 621e25388fd 3d4df8d2d82 Author: Johan Commelin <[email protected]> Date: Wed Jun 26 06:08:57 2024 +0000 Merge branch 'bump/nightly-2024-06-25' into nightly-testing commit 3d4df8d2d82389cd79e18df70c2e9497a34bf2f3 Author: Johan Commelin <[email protected]> Date: Wed Jun 26 05:51:45 2024 +0000 chore: adaptations for nightly-2024-06-25 commit 621e25388fd7ffdf11fbca6cc000f3d6d069c0d4 Merge: e5f33def5c6 022088daa10 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 26 03:32:53 2024 +0000 Merge master into nightly-testing commit e5f33def5c658eda0923f2aca22c098e2a43dfb9 Merge: 40d12f6afc2 46b048d49f8 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 26 00:45:07 2024 +0000 Merge master into nightly-testing commit 40d12f6afc28e926e06cff31e0c0fa6bab04d211 Merge: 6603d28d47a 9cff34c8c3b Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 25 21:31:17 2024 +0000 Merge master into nightly-testing commit 6603d28d47a3ecc279e98b3a083830293be2cd93 Merge: 4dd32d31809 92882dd7a32 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 25 18:33:46 2024 +0000 Merge master into nightly-testing commit 4dd32d3180981560bf017b79f703618cce4c8c98 Merge: 07572761484 7e4afad324f Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 25 15:31:09 2024 +0000 Merge master into nightly-testing commit 07572761484845d417dc56526a38710c5bf3f4f1 Merge: 50b55cfa66e cd7c51790ca Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 25 12:40:09 2024 +0000 Merge master into nightly-testing commit 50b55cfa66e16b35dd889902ba2246a4ab23819e Merge: ea2e520bc6f 2378e649c5c Author: Kim Morrison <[email protected]> Date: Tue Jun 25 21:43:35 2024 +1000 merge bump/v4.10.0 commit ea2e520bc6f7715acbb21c774f67b249cca5b0da Author: Kim Morrison <[email protected]> Date: Tue Jun 25 21:42:44 2024 +1000 fix Archive commit a030fc11ed9759ed700afdc0b4f019cdb98e21f3 Merge: 9027468b351 ef89cf3f9f9 Author: Kim Morrison <[email protected]> Date: Tue Jun 25 20:49:15 2024 +1000 Merge branch 'nightly-testing' of github.com:leanprover-community/mathlib4 into nightly-testing commit 9027468b3510efa52b5e631c6f7eb7ed8159b5c0 Author: Kim Morrison <[email protected]> Date: Tue Jun 25 20:49:05 2024 +1000 fix commit ef89cf3f9f9b69267e6f5b5759522f59cd3ac103 Merge: a9af61ff2db 397d87803ee Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 25 09:31:03 2024 +0000 Merge master into nightly-testing commit a9af61ff2db0ee5228e64cb23a7f57e077eac2f0 Author: Kim Morrison <[email protected]> Date: Tue Jun 25 18:51:59 2024 +1000 fix commit 466cf4f0f37a1511a4b883766ef0577770e84e93 Author: Kim Morrison <[email protected]> Date: Tue Jun 25 18:51:21 2024 +1000 bump toolchain and batteries commit c67ed6593f888875a11d44e0aea3a90536ce8c7b Merge: 2169a2f0a63 b0f8ad0287b Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 25 06:34:36 2024 +0000 Merge master into nightly-testing commit 2169a2f0a631a2a6d15b23f96201837b145e8e6d Merge: 7c6bc39bbfa 55f624049c3 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 25 03:31:58 2024 +0000 Merge master into nightly-testing commit 7c6bc39bbfa073f10561aa44e6d4ca6f16d49d31 Merge: 5d2abb28b4f 9b48e040b41 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 25 00:45:02 2024 +0000 Merge master into nightly-testing commit 5d2abb28b4faa1507ab3b85f91ef6a11b8ac8951 Merge: d3e8455dbbd 8869371744c Author: leanprover-community-mathlib4-bot <[email protected]> Date: Mon Jun 24 21:31:02 2024 +0000 Merge master into nightly-testing commit d3e8455dbbdce2108ae3c62b72173e1ad110bcb2 Merge: 4943b11c487 a3001aa1c78 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Mon Jun 24 18:33:33 2024 +0000 Merge master into nightly-testing commit 4943b11c487c16533312a5760d3c9f8c69819b8b Merge: c1814e0f1a5 56664ede1ed Author: leanprover-community-mathlib4-bot <[email protected]> Date: Mon Jun 24 15:31:02 2024 +0000 Merge master into nightly-testing commit c1814e0f1a54c21d7c57354e3812903c55029a4a Merge: bcc63ea1006 56af6096583 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Mon Jun 24 12:40:41 2024 +0000 Merge master into nightly-testing commit bcc63ea1006ad04009a52d601918d9d442d81b10 Author: Kim Morrison <[email protected]> Date: Mon Jun 24 21:01:16 2024 +1000 fix tests commit 6dde481b6fbd62adcc542c26ce169c094e757221 Merge: 704698e9b17 cd06eb881dd Author: Kim Morrison <[email protected]> Date: Mon Jun 24 19:34:51 2024 +1000 merge lean-pr-testing-4493 commit 704698e9b174fc10478e78d93edaec3df01fe77b Author: Kim Morrison <[email protected]> Date: Mon Jun 24 19:34:18 2024 +1000 bump commit 6a859c231d0e21c3aacea117cb00186cacc07f67 Merge: 88b7a1e766b 0eb87504b21 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Mon Jun 24 09:31:28 2024 +0000 Merge master into nightly-testing commit 88b7a1e766ba3d6263660f1b85516c1e6d4666f2 Merge: d98af9776d1 62fdad82b24 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Mon Jun 24 03:31:43 2024 +0000 Merge master into nightly-testing commit d98af9776d16f63838924a337b20698c870a1b5d Author: Kim Morrison <[email protected]> Date: Mon Jun 24 11:58:19 2024 +1000 fix IfNormalization commit 8ea5ec9dcd8d6af43e4e79005de79e69bee40a90 Author: Kim Morrison <[email protected]> Date: Mon Jun 24 11:56:31 2024 +1000 fix commit c74738caf5f72311534f7c88ecfdaad89d7c0086 Merge: 49004156160 24503aae89c Author: Kim Morrison <[email protected]> Date: Mon Jun 24 11:41:46 2024 +1000 merge bump/v4.10.0 commit cd06eb881dde5f674f26387d6487434dd8dd052f Author: Kim Morrison <[email protected]> Date: Mon Jun 24 11:15:54 2024 +1000 fix commit 49004156160905cb134d55ae8e2ed56fb588bf04 Merge: 2b5dada4ea8 fca6b3ac0ba Author: leanprover-community-mathlib4-bot <[email protected]> Date: Mon Jun 24 00:45:08 2024 +0000 Merge master into nightly-testing commit 2b5dada4ea85c444174b63fe2d95b4bccd7cb58e Author: Kim Morrison <[email protected]> Date: Mon Jun 24 10:42:07 2024 +1000 fix Archive commit 9bd7335cb551dd80d507ad8931aa5202b68e40c4 Author: Kim Morrison <[email protected]> Date: Mon Jun 24 10:13:20 2024 +1000 fixes commit 9b422c056639e6a481ff86617c066a24d9fcf1a7 Author: Kim Morrison <[email protected]> Date: Mon Jun 24 09:19:20 2024 +1000 fix commit c6fef4778bef4be459483e3f409c79275795d568 Merge: 19c171a7ecb 1616f72b4a8 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 23 18:32:13 2024 +0000 Merge master into nightly-testing commit 19c171a7ecb5de069f38298c4d949469df3d5f92 Merge: 9b1582634e5 5c12fd768f4 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 23 15:31:09 2024 +0000 Merge master into nightly-testing commit 9b1582634e5bf6c98522143cd1975b0a5c29abd7 Merge: c47d740c6a7 4e1840add86 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 23 12:38:44 2024 +0000 Merge master into nightly-testing commit c47d740c6a78ba56582f9a7120a4e5e7f2c42c76 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 23 10:03:00 2024 +0000 chore: bump to nightly-2024-06-23 commit 38b9bd2199a6c0060dcb1639b9fda459f64674b7 Merge: f5966d541a4 7cac44b5d26 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 23 09:31:03 2024 +0000 Merge master into nightly-testing commit f5966d541a4dd0c75658b9f4b7302eede70459e7 Merge: 1353c3a974f 92377b4d13c Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 23 06:33:20 2024 +0000 Merge master into nightly-testing commit 1353c3a974ff77248c597a3b84d5efa018ec1e14 Merge: 10315e9dad6 8ca314116d1 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 23 03:31:08 2024 +0000 Merge master into nightly-testing commit 10315e9dad676a180a12624f7181b468b0383018 Merge: 052eeaf9218 ec3b4c9bfba Author: Kim Morrison <[email protected]> Date: Sun Jun 23 10:55:22 2024 +1000 Merge branch 'bump/nightly-2024-06-22' into nightly-testing commit ec3b4c9bfba6f92b45f6613e9831a9db71832b76 Author: Kim Morrison <[email protected]> Date: Sun Jun 23 10:55:14 2024 +1000 fix merge commit 052eeaf9218514a274b19358c92a21863682c7e5 Merge: a2b61b941ea 97c84bdd908 Author: Kim Morrison <[email protected]> Date: Sun Jun 23 10:54:15 2024 +1000 Merge branch 'bump/nightly-2024-06-22' into nightly-testing commit 97c84bdd90892be5cd7e213bd8c62c335a9bfd85 Author: Kim Morrison <[email protected]> Date: Sun Jun 23 10:54:01 2024 +1000 remove adaptation note commit a2b61b941ea51a369a1e8adfbdfc4244a6a560a3 Merge: 6921b1f141d f217bf564f6 Author: Kim Morrison <[email protected]> Date: Sun Jun 23 10:45:30 2024 +1000 Merge branch 'bump/nightly-2024-06-22' into nightly-testing commit f217bf564f6812074c8ea2f2ab61edc983a6a858 Author: Kim Morrison <[email protected]> Date: Sun Jun 23 10:44:09 2024 +1000 fix commit 434d52882d3449070b47a47e70c8537b9bfa9aa6 Author: Kim Morrison <[email protected]> Date: Sun Jun 23 10:42:44 2024 +1000 fix comment commit 0bb2997d777941d709c07b0f20d2338b030b48b6 Author: Kim Morrison <[email protected]> Date: Sun Jun 23 10:42:04 2024 +1000 cleanup adaptation note commit 79d40f368a8650850e2c051c4c50b4990aa03442 Author: Kim Morrison <[email protected]> Date: Sun Jun 23 10:40:30 2024 +1000 fix merge commit f2d9d382d39668abc853a5430012bde8c3f6587e Author: Kim Morrison <[email protected]> Date: Sun Jun 23 10:39:55 2024 +1000 fix merge commit 6921b1f141d77f1fd1edbdfa6ce4c96d47e36dc7 Merge: 5cf0cbefbf5 17f50b30af5 Author: Kim Morrison <[email protected]> Date: Sun Jun 23 10:37:55 2024 +1000 Merge branch 'bump/nightly-2024-06-22' into nightly-testing commit 17f50b30af5bc62fbf449e2700be1b6db146548d Author: Kim Morrison <[email protected]> Date: Sun Jun 23 10:37:33 2024 +1000 chore: adaptations for nightly-2024-06-22 commit 5cf0cbefbf55fbbac1b71322db10755b818a0519 Author: Kim Morrison <[email protected]> Date: Sun Jun 23 10:35:06 2024 +1000 Fix variables statement commit 5f3592907faca8a9aee8aa99af393aafb0a25687 Merge: b45e23ae072 618674590fe Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 22 21:31:17 2024 +0000 Merge master into nightly-testing commit b45e23ae0724c417e1294d75b052ca8619cbdc2c Merge: 3d0afb9aadf e4a15fb2495 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 22 18:32:31 2024 +0000 Merge master into nightly-testing commit 3d0afb9aadf407fff6739610a5c58716c9c19176 Merge: 43a4231c27e 5c1bf5e7e26 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 22 15:31:01 2024 +0000 Merge master into nightly-testing commit 43a4231c27e84aeb286cc1308f6485d798600265 Merge: 6ada2294550 eb89176fcde Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 22 12:38:39 2024 +0000 Merge master into nightly-testing commit 6ada22945503d03d67b968837b8709b1c1eb333c Author: Kim Morrison <[email protected]> Date: Sat Jun 22 21:11:10 2024 +1000 fix commit 64cbd5d92b9174a30ea653cf1e9d5df568caba01 Merge: d98fc759fc0 074768e1901 Author: Kim Morrison <[email protected]> Date: Sat Jun 22 20:54:09 2024 +1000 merge lean-pr-testing-4500 commit d98fc759fc02cd05bc12ef1a04b3fa35c279ba93 Author: Kim Morrison <[email protected]> Date: Sat Jun 22 20:53:37 2024 +1000 fixes commit ca6911d4afb8191595c1fefbfd0ecdf3ebc0a74e Author: Kim Morrison <[email protected]> Date: Sat Jun 22 20:50:39 2024 +1000 fixes commit 67d228b9e035cac8c1ccbff5feabf04808a3cd72 Author: Kim Morrison <[email protected]> Date: Sat Jun 22 20:46:03 2024 +1000 fix commit afc43ba1ee390fe41218bab6035bf2c6ff34e3ad Author: Kim Morrison <[email protected]> Date: Sat Jun 22 20:45:39 2024 +1000 bump batteries commit e1a0701c24bec0be44e982470e8411686c80db85 Author: Kim Morrison <[email protected]> Date: Sat Jun 22 20:44:09 2024 +1000 fix HelpCmd commit e7166d2b38b07d31c452eac8add6cba980febe3c Merge: dd819f526ce b679875854c Author: Kim Morrison <[email protected]> Date: Sat Jun 22 20:39:45 2024 +1000 Merge branch 'nightly-testing' of github.com:leanprover-community/mathlib4 into nightly-testing commit dd819f526ce7e80a40cceeb246f1c8eeb4393132 Author: Kim Morrison <[email protected]> Date: Sat Jun 22 20:39:34 2024 +1000 fixes commit b679875854ccd325d943ba25cd8fd597cfc032ec Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 22 10:02:47 2024 +0000 chore: bump to nightly-2024-06-22 commit aec22edbf7a30934725c808e3a3e045d1e667c89 Merge: 937549af1ea ab0de47a159 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 22 09:31:18 2024 +0000 Merge master into nightly-testing commit 937549af1eaa38d73be9c4155f27332516cf90de Merge: 7416e2056ef 23725d3c75b Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 22 00:44:59 2024 +0000 Merge master into nightly-testing commit 7416e2056efcacb57235921b261ee8e5e395166b Merge: 7d047496224 b732d172c8d Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 21 21:31:11 2024 +0000 Merge master into nightly-testing commit 7d04749622488ca145137a684aee324c544791f6 Merge: 9746e161e63 2176d73b65e Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 21 18:33:41 2024 +0000 Merge master into nightly-testing commit 9746e161e63c6956272e428fa6a868db7c0e4f29 Merge: 2be64c7cd3b 0be623aea6b Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 21 12:39:36 2024 +0000 Merge master into nightly-testing commit 2be64c7cd3b1efeb9314012333de38237e960eb8 Author: Kim Morrison <[email protected]> Date: Fri Jun 21 21:38:20 2024 +1000 fix commit 662209fa40f2c766f473b22b0726a9cfef63b01f Author: Kim Morrison <[email protected]> Date: Fri Jun 21 21:36:09 2024 +1000 fixes commit 7e6db92f31c473eef5bc4b66c28507b3f2a847a2 Author: Kim Morrison <[email protected]> Date: Fri Jun 21 20:54:21 2024 +1000 fixes commit 7f26554080d3fe27d95a3bae85b0c4bb3836148d Merge: fd9ad7a06b0 f8dbff04b02 Author: Kim Morrison <[email protected]> Date: Fri Jun 21 20:44:12 2024 +1000 merge lean-pr-testing-3850 commit fd9ad7a06b0902f34745b024be1f3d2e31907587 Author: Kim Morrison <[email protected]> Date: Fri Jun 21 20:43:46 2024 +1000 fixes commit 365ad6c61e01ad36249ff9e0269b4ed6b30b76c7 Author: Kim Morrison <[email protected]> Date: Fri Jun 21 20:41:55 2024 +1000 bump dependencies commit 7f0616f70cd284c4716d45a25edb129ebfaec501 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 21 10:02:58 2024 +0000 chore: bump to nightly-2024-06-21 commit 28153eeb6643eeb17d92d898c68232f83c5a080a Merge: e727bee5ba8 00d112fb174 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 21 09:31:07 2024 +0000 Merge master into nightly-testing commit e727bee5ba81d00421805d6bb5f0be6e9adbaee5 Merge: 66db003e384 2399abd4094 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 21 03:32:35 2024 +0000 Merge master into nightly-testing commit 66db003e3842fac60f02e77b3dc406b73ee31594 Author: Kim Morrison <[email protected]> Date: Fri Jun 21 11:21:49 2024 +1000 bump batteries commit f0525f7b593a2d9a47942d9c79a5d560c7dbcc1f Merge: cb34b6ab0cb 19f8cc69f95 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 20 21:31:22 2024 +0000 Merge master into nightly-testing commit cb34b6ab0cb9d62580397bee1293d450928d8731 Merge: 43e9b813413 99cf0930154 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 20 18:33:08 2024 +0000 Merge master into nightly-testing commit 43e9b81341308a27fac23360e27e9c24a79cd1f4 Merge: 16274d3e5d0 e5ebb89f2ae Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 20 15:32:08 2024 +0000 Merge master into nightly-testing commit 16274d3e5d086404958a2be990849522a02810c4 Merge: b796f9801cf 2dec5ec3be6 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 20 12:39:59 2024 +0000 Merge master into nightly-testing commit 074768e1901378ba339d569897fcbdc9a372d722 Author: Markus Schmaus <[email protected]> Date: Thu Jun 20 11:43:42 2024 +0200 chore: empty commit to trigger CI commit b796f9801cf2bf5cbac1fb817a8f8a94fbad29ad Merge: 859f0f47c57 7c80fcc7d53 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 20 09:31:19 2024 +0000 Merge master into nightly-testing commit 859f0f47c57000857ca27edd0f3a1895eeebf29a Merge: 9386caf1b14 6b876736761 Author: Kim Morrison <[email protected]> Date: Thu Jun 20 15:48:05 2024 +1000 merge bump/v4.10.0 commit f8dbff04b020de1f87b372d7ebf759f76ded9557 Author: Kim Morrison <[email protected]> Date: Thu Jun 20 14:36:06 2024 +1000 fix commit 800313d5237e499f372a622c18a5866e2470bec2 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Apr 9 07:01:25 2024 +0000 Trigger CI for https://github.com/leanprover/lean4/pull/3850 commit fe087e9299e159164d974868d7ce12002c3d3eb5 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Apr 9 06:26:02 2024 +0000 Update lean-toolchain for testing https://github.com/leanprover/lean4/pull/3850 commit 9386caf1b14a77b03398a6b877009476373db20a Author: Kim Morrison <[email protected]> Date: Thu Jun 20 14:20:20 2024 +1000 fixes commit d77273ff511fe7a10584b93ee8a8361b03982888 Author: Kim Morrison <[email protected]> Date: Thu Jun 20 13:55:23 2024 +1000 linting commit a593eca2da67ba6daed8b308cb20d8b26270fe7b Author: Kim Morrison <[email protected]> Date: Thu Jun 20 13:39:40 2024 +1000 fix batteries dependency commit 4d2c7216bb30f57b3d69d70e0bc9a730ffb3f85f Merge: db93fee016c 2e6f6dff0e3 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 20 03:31:53 2024 +0000 Merge master into nightly-testing commit db93fee016c445566220e74c22e90a0e9ec126e2 Author: Kim Morrison <[email protected]> Date: Thu Jun 20 13:30:58 2024 +1000 shake commit d55762950cb9b38a9617c9608ef0dcd5f2b24da7 Author: Markus Schmaus <[email protected]> Date: Thu Jun 20 05:07:17 2024 +0200 chore: empty commit to trigger CI commit a0412b2596d1ee5a10847a4dedfcc43dfa55f44c Author: Kim Morrison <[email protected]> Date: Thu Jun 20 12:47:56 2024 +1000 last fixes commit 01062c454bb14998a03cc4d9bd06933336fbfe65 Author: Kim Morrison <[email protected]> Date: Thu Jun 20 12:43:20 2024 +1000 fixes commit c9294229ef7e268abef0cc4b8c8f70f7a4d2dd6c Author: Kim Morrison <[email protected]> Date: Thu Jun 20 12:28:48 2024 +1000 fixes commit 74a9085692b0bf38fc1172c253a8bfd56b16a731 Author: Kim Morrison <[email protected]> Date: Thu Jun 20 11:58:10 2024 +1000 fixes commit a2db0817991b7364370cc0a58c9726af3458f888 Merge: 0e183b94dfa 0a17a6a17d8 Author: Kim Morrison <[email protected]> Date: Thu Jun 20 11:52:15 2024 +1000 merge lean-pr-testing-4387 commit 0e183b94dfa806620285e001e15c397fb3df6773 Author: Kim Morrison <[email protected]> Date: Thu Jun 20 11:50:48 2024 +1000 fixes commit 0415908a05bac998cefab3ac948ce312fa2be3c8 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 20 01:31:29 2024 +0000 Trigger CI for https://github.com/leanprover/lean4/pull/4493 commit 9a4f62bd59bb4acf5fde87dc4117030d880a5375 Merge: cb5f45e442e 4bf28bb810d Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 19 21:30:59 2024 +0000 Merge master into nightly-testing commit cb5f45e442e5e27dd6dca229ac0849b4102807c1 Merge: 4dc6a5937f6 1e77bedde85 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 19 18:33:48 2024 +0000 Merge master into nightly-testing commit 4dc6a5937f625971d9bd96344cc8d369fcd0bb21 Merge: 00bbdee5914 9f09963d772 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 19 15:31:07 2024 +0000 Merge master into nightly-testing commit 84aa73aee5637d3d5da924e3ff149f840a24d6db Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 19 14:11:43 2024 +0000 Trigger CI for https://github.com/leanprover/lean4/pull/4500 commit 65ab5857f68a0bd006816aa1cd775ed041b2e88c Author: Markus Schmaus <[email protected]> Date: Wed Jun 19 16:04:19 2024 +0200 fix: remove unnecessary `succ_eq_add_one` commit 279f95d405c50eab23a11dbdca21a641b7f78def Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 19 12:48:14 2024 +0000 Update lean-toolchain for testing https://github.com/leanprover/lean4/pull/4500 commit 00bbdee591435599ba7e913ba02dc12f87476582 Merge: 775cc9c39bd 435827ab492 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 19 12:40:30 2024 +0000 Merge master into nightly-testing commit 775cc9c39bd25e2c0f248fbc0fb8b84bc283b769 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 19 10:02:50 2024 +0000 chore: bump to nightly-2024-06-19 commit 3ef4272a0d4fe6d4a647029e47ede3782f36b2b1 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 19 09:32:19 2024 +0000 Merge master into nightly-testing commit b275ee3b1b0a2809c592d81ca8adde9ea003ed06 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 18 23:24:58 2024 +0000 Update lean-toolchain for testing https://github.com/leanprover/lean4/pull/4493 commit d19905f4b771f398334acc25c2ff9e04c0109d41 Merge: 4a0e11da9c7 b84002db251 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 18 21:31:07 2024 +0000 Merge master into nightly-testing commit 4a0e11da9c7520c7cdb8802bca167641672e0e51 Merge: bc534b4d3a8 6f05744dbb8 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 18 18:33:43 2024 +0000 Merge master into nightly-testing commit bc534b4d3a87bd3f781e477d4a8a4346241df943 Merge: 0317d92500f 3683cd05bdf Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 18 15:31:04 2024 +0000 Merge master into nightly-testing commit 0317d92500fcc0835f2af8165946bf4f6f85062d Merge: a920b4c9309 aa2b73340b7 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 18 12:40:22 2024 +0000 Merge master into nightly-testing commit a920b4c9309266d52e46a366588f42cad801eb70 Merge: 71abc9230db 79423dc5b7a Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 18 09:31:05 2024 +0000 Merge master into nightly-testing commit 71abc9230db929630a731188efbac89ed4d61c6f Author: Kim Morrison <[email protected]> Date: Tue Jun 18 19:30:21 2024 +1000 . commit 039ffdb49623bfccea9fa188c0ea022ce0980a32 Author: Kim Morrison <[email protected]> Date: Tue Jun 18 19:17:35 2024 +1000 rm upstreamed commit 37ba65e114801b87c388bd84619b89e671b351a8 Author: Kim Morrison <[email protected]> Date: Tue Jun 18 19:17:01 2024 +1000 fixes commit 10ef356ae1145d893c2a1afcd6e775a671dd142e Author: Kim Morrison <[email protected]> Date: Tue Jun 18 19:15:11 2024 +1000 bump toolchain commit b85a253230eed78a2b71d07c8d39c773eaf7c83b Author: Kim Morrison <[email protected]> Date: Tue Jun 18 19:14:41 2024 +1000 bump batteries commit f4ad29f61d68a09e25972821f0c6cbebd0f252fa Author: Kim Morrison <[email protected]> Date: Tue Jun 18 19:06:17 2024 +1000 typo commit dc21b009d754efb30b1450893e511e9171cb04d7 Author: Kim Morrison <[email protected]> Date: Tue Jun 18 18:40:22 2024 +1000 delete BinaryHeap commit f85ec1760b5df6c1234a68189b253dc737ce3e76 Merge: 3456892ecef 27c6744e1c0 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 18 06:34:17 2024 +0000 Merge master into nightly-testing commit 3456892eceff700d46f7d0e073fb0260ed7bb09b Merge: e43c6537e2b 1db89cb519e Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 18 03:32:51 2024 +0000 Merge master into nightly-testing commit e43c6537e2b7a0eb2d46934884b7c51d67389fd1 Merge: 8c571f88557 ae4167de90c Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 18 00:45:05 2024 +0000 Merge master into nightly-testing commit 8c571f88557f69b347bc51ae9e10df6ba4fc9d41 Merge: 97285087c10 72d08e5f1a1 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Mon Jun 17 21:31:17 2024 +0000 Merge master into nightly-testing commit 97285087c1005d5d0d55473d640dca35b8e999e3 Merge: d2acb01a38b 009daa3a647 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Mon Jun 17 18:33:32 2024 +0000 Merge master into nightly-testing commit d2acb01a38b8eeeb95942a0eff150300d1b1f234 Merge: 80cda2bf67e 739a018e1c1 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Mon Jun 17 15:31:31 2024 +0000 Merge master into nightly-testing commit 80cda2bf67e0cb5cf26a6c0c689e268ca8bd3ec6 Merge: 0c03b6e989a bdd39e92aed Author: leanprover-community-mathlib4-bot <[email protected]> Date: Mon Jun 17 12:40:28 2024 +0000 Merge master into nightly-testing commit 0c03b6e989a6faed7dd24e50095172e8968b8d5a Author: Kim Morrison <[email protected]> Date: Mon Jun 17 20:52:37 2024 +1000 deprecation commit a00035cd58f2ca8881f5ab9cd44d0c6156d8aa01 Author: Kim Morrison <[email protected]> Date: Mon Jun 17 20:39:50 2024 +1000 deprecations commit 83acde38d72d86228e5c89c24ab4cea04806ea0b Author: Kim Morrison <[email protected]> Date: Mon Jun 17 18:37:58 2024 +1000 deprecation commit a0daee52b4e73cae233f1abec330e4118e80242f Author: Kim Morrison <[email protected]> Date: Mon Jun 17 18:36:09 2024 +1000 fix commit 7240a6adb9e4c93c64cfd0885916ccd67d8a413d Author: Kim Morrison <[email protected]> Date: Mon Jun 17 18:31:31 2024 +1000 fix commit 84a60b0c42a5a0e0b8ae32c7ad5ce2b7eb4b9bf7 Merge: fb1274cde6d c73e7e8fced Author: Kim Morrison <[email protected]> Date: Mon Jun 17 18:05:02 2024 +1000 merge lean-pr-testing-4242 commit fb1274cde6dbc6bc1464117ee0b4b9e8b7f40f16 Merge: bcd33ba73d5 21bb971b895 Author: Kim Morrison <[email protected]> Date: Mon Jun 17 18:03:34 2024 +1000 merge lean-pr-testing-4242 commit bcd33ba73d5c50404b39a65091c6662287e56b6e Author: Kim Morrison <[email protected]> Date: Mon Jun 17 18:02:48 2024 +1000 oops commit b7dec990d0976e061a153e7ced5fff8123444dfd Merge: adec65aab9e 3b2ed882c41 Author: Kim Morrison <[email protected]> Date: Mon Jun 17 18:02:06 2024 +1000 merge lean-pr-testing-4469 commit adec65aab9ea5d6c2f6e95ee3463e6b4c655f5b9 Author: Kim Morrison <[email protected]> Date: Mon Jun 17 18:01:37 2024 +1000 bump toolchain commit 3b2ed882c4156c956fadb16b96d1667d62b2461b Author: leanprover-community-mathlib4-bot <[email protected]> Date: Mon Jun 17 04:03:09 2024 +0000 Trigger CI for https://github.com/leanprover/lean4/pull/4469 commit f411bcc3e01a6dccd492e944bc127af2543d72e4 Author: Kim Morrison <[email protected]> Date: Mon Jun 17 13:34:36 2024 +1000 deprecations commit 29d17b521ffe801221f878fe352f60babb055359 Author: Kim Morrison <[email protected]> Date: Mon Jun 17 13:10:48 2024 +1000 fixing errors blind commit b28978755a9eca875548bd1c87f4a7bef127fe70 Author: Kim Morrison <[email protected]> Date: Mon Jun 17 12:48:26 2024 +1000 bump batteries by hand; no toolchain yet commit cc87eed813b099383b7d9ad53295fbe093b46caf Author: leanprover-community-mathlib4-bot <[email protected]> Date: Mon Jun 17 02:37:09 2024 +0000 Update lean-toolchain for testing https://github.com/leanprover/lean4/pull/4469 commit 6177b17e82a6a0d75a425429d517ea40ca493fad Merge: 2353b0a9148 e1346507b45 Author: Kim Morrison <[email protected]> Date: Mon Jun 17 11:35:03 2024 +1000 Merge branch 'nightly-testing' of github.com:leanprover-community/mathlib4 into nightly-testing commit 2353b0a9148524183245793a67127a1a55bf1c80 Author: Kim Morrison <[email protected]> Date: Mon Jun 17 11:34:50 2024 +1000 shake commit e1346507b45c9aecd6de064c30b8743aa9e6c021 Merge: f822202bcf9 77e1ea0a339 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Mon Jun 17 00:45:10 2024 +0000 Merge master into nightly-testing commit f822202bcf9a3c65d61bfb96a42bfa4331d543c5 Merge: 063c772f963 633175e9685 Author: Kim Morrison <[email protected]> Date: Mon Jun 17 09:09:56 2024 +1000 merge lean-pr-testing-4400 commit 063c772f963bb17e816b98eeb513f1b0326b929e Author: Kim Morrison <[email protected]> Date: Mon Jun 17 09:06:10 2024 +1000 bump batteries commit 38080755dc5860f5f055dbb65d47857bc9fd6023 Merge: 7ebb1e39c90 782e4af4347 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 16 21:30:54 2024 +0000 Merge master into nightly-testing commit 7ebb1e39c904b3d3d8f1623d4a0a05dbc708aab9 Merge: a122106f9f9 d394d9f4486 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 16 15:31:12 2024 +0000 Merge master into nightly-testing commit a122106f9f9bafe15c4c3ab78f14d3c0b0c536c8 Merge: 958592f6898 950e3d06575 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 16 12:39:01 2024 +0000 Merge master into nightly-testing commit 958592f689818fd9b2a35b6352210d960659516a Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 16 10:03:02 2024 +0000 chore: bump to nightly-2024-06-16 commit 2da7f9082a4c8b18f8299d3f4e04a9a7cc36a320 Merge: 5b5f57955be f47614aab49 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 16 09:31:07 2024 +0000 Merge master into nightly-testing commit 5b5f57955be702eeac2a5656ce05f00c585db859 Author: Kim Morrison <[email protected]> Date: Sun Jun 16 17:01:08 2024 +1000 remove adaptation note commit 930c82600da6499ef7f94e6ff3ac784d5d7db79f Merge: 3ffb86be690 46b526ec746 Author: Kim Morrison <[email protected]> Date: Sun Jun 16 11:47:05 2024 +1000 merge master commit 3ffb86be6904e1a68c83d4522d54bac2ecf62cd2 Merge: c4fae0d0b0b 7dc413fef53 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sun Jun 16 00:45:17 2024 +0000 Merge master into nightly-testing commit c4fae0d0b0bbc225b0a62bd517baf14038a8bd69 Merge: aa161a61c2a 12f0f6e37d7 Author: Kim Morrison <[email protected]> Date: Sun Jun 16 10:27:28 2024 +1000 merge bump/v4.10.0 commit aa161a61c2a87fc79a60ee05e4a7a42d1284354e Author: Kim Morrison <[email protected]> Date: Sun Jun 16 10:10:22 2024 +1000 bump importGraph to nightly-testing branch commit ff12d5211e064b6db1b269f2dca7cad5a726847b Merge: 1a8c8ac0bbf 03092720f68 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 15 21:31:04 2024 +0000 Merge master into nightly-testing commit 1a8c8ac0bbf623d2358dbe5221128a6c05e4f4fb Merge: 91276f30d64 a9fbabf8a72 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 15 18:33:04 2024 +0000 Merge master into nightly-testing commit 91276f30d640524f3dc527caf98dc812ad6047a6 Merge: 9f53402c56e 90b6f6d9e27 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 15 15:31:06 2024 +0000 Merge master into nightly-testing commit 9f53402c56ec2a1ac98aa2ae0aa24a12f93ba13a Author: Kim Morrison <[email protected]> Date: Sat Jun 15 20:33:03 2024 +1000 oops commit dc5ec71551bbc61a7869f724d9d2525ab1191363 Author: Kim Morrison <[email protected]> Date: Sat Jun 15 20:28:54 2024 +1000 remove imports commit 64f0e6fb1d4c1eeea4375e051a621cba88d3ff31 Merge: 84edf4dd79b fcabff1b10d Author: Kim Morrison <[email protected]> Date: Sat Jun 15 20:06:30 2024 +1000 Merge branch 'nightly-testing' of github.com:leanprover-community/mathlib4 into nightly-testing commit 84edf4dd79be8d52a8dd0bda1c678a25a146ceed Author: Kim Morrison <[email protected]> Date: Sat Jun 15 20:05:17 2024 +1000 rebuild manifest commit fcabff1b10dfa9842f3aef9acfc38fd3cff999c4 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 15 10:02:49 2024 +0000 chore: bump to nightly-2024-06-15 commit f886fe83eaac953d78cee018cbf3c19a5fd5f73c Merge: 7f118234567 f6c43c61dde Author: leanprover-community-mathlib4-bot <[email protected]> Date: Sat Jun 15 09:31:08 2024 +0000 Merge master into nightly-testing commit 7f118234567e302e4cf3df09abab52f1bb10ec64 Author: Kim Morrison <[email protected]> Date: Sat Jun 15 16:46:27 2024 +1000 bump commit ac41ca05f3adcc0b540b7fa32353b092a34d1142 Merge: 1a7590c0b91 f05cf142c2f Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 14 18:33:57 2024 +0000 Merge master into nightly-testing commit 1a7590c0b91038bc0e0aacb82163c9cde0693cd5 Merge: 9513f1b3457 11731ee18f3 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 14 15:31:31 2024 +0000 Merge master into nightly-testing commit 9513f1b3457da73dd54bfd078cc4e39a7f97175b Merge: 97cea05cd94 2268f788bfe Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 14 12:40:13 2024 +0000 Merge master into nightly-testing commit 97cea05cd94428dd074df3d8b4cefb728ac76a04 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 14 10:02:48 2024 +0000 chore: bump to nightly-2024-06-14 commit 933057b6f0e6c13a8471f3906efaee6396d4d4f1 Merge: 089f9f8aacb c07d988501e Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 14 09:31:34 2024 +0000 Merge master into nightly-testing commit 089f9f8aacb129fa9d3a1e0d42d48d27938491a1 Merge: 6e65b9b485e 5ef3a830c97 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 14 06:34:16 2024 +0000 Merge master into nightly-testing commit 633175e96851c133890cc01cc8c35dfe9b27581f Author: Kim Morrison <[email protected]> Date: Fri Jun 14 14:55:02 2024 +1000 lint commit 60ab68660d0e2839da3c89cd04ddea2764f4c3d8 Author: Kim Morrison <[email protected]> Date: Fri Jun 14 14:52:34 2024 +1000 lint commit 2592cf2f488a14369150816bf2241d6b76333928 Author: Kim Morrison <[email protected]> Date: Fri Jun 14 11:50:09 2024 +1000 Update Mathlib/Data/List/Basic.lean Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit 6d26baa266d5c0ba5ebdf4eea8171b65f9e4b818 Merge: 626f8d9d822 6e65b9b485e Author: Kim Morrison <[email protected]> Date: Fri Jun 14 11:31:35 2024 +1000 Merge remote-tracking branch 'origin/nightly-testing' into lean-pr-testing-4400 commit 6e65b9b485e201c578d2a73e381e27982542566f Merge: 185931f8393 ceff16fcda8 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Fri Jun 14 00:45:03 2024 +0000 Merge master into nightly-testing commit 185931f83938da91b06399237f678c9824a6512f Merge: ec1cccfcaf5 c9f95f42b82 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 13 21:31:09 2024 +0000 Merge master into nightly-testing commit ec1cccfcaf503f6876729401cd1b14c8c3c6c339 Merge: b9178a5b109 1e62b3f4e8f Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 13 18:33:59 2024 +0000 Merge master into nightly-testing commit b9178a5b109c3b4b6a56283c927b8e924c6c5b46 Merge: c988d72f0ac 5515fe8cdf2 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 13 15:31:07 2024 +0000 Merge master into nightly-testing commit c988d72f0ac2e3264ae30e02254941cb9da207bb Merge: 1cf8aeef155 659d35143a8 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 13 12:42:41 2024 +0000 Merge master into nightly-testing commit 1cf8aeef155791698df2f724982c69a9ccee2ea2 Merge: 68ea3de7cd9 65ff3ef3682 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 13 09:31:06 2024 +0000 Merge master into nightly-testing commit 626f8d9d822a25b4ba04f4bff8287de162621f8b Author: Kim Morrison <[email protected]> Date: Thu Jun 13 19:05:31 2024 +1000 fixes commit 0d6ffda401d556e81f599c228edd55f2b5596cfb Author: Kim Morrison <[email protected]> Date: Thu Jun 13 16:51:57 2024 +1000 bump commit a598d4e036489f0da00d045c9c18402701bf46a1 Author: Kim Morrison <[email protected]> Date: Thu Jun 13 16:43:06 2024 +1000 bump commit c8de13c720778cf72e1791cde454b5f56efa8293 Author: Kim Morrison <[email protected]> Date: Thu Jun 13 16:39:17 2024 +1000 deprecations commit 68ea3de7cd9d80ac477c65e1bd037f67a3805265 Merge: a4383ad9adf cc10402b8dd Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 13 06:33:45 2024 +0000 Merge master into nightly-testing commit 7d840a3b3e60d0bfce93b892f0e312d54423acdc Author: Kim Morrison <[email protected]> Date: Thu Jun 13 16:13:43 2024 +1000 bump commit c9d416f0791ec06898de80866c80323f32652367 Merge: 6107a90d4b2 a4383ad9adf Author: Kim Morrison <[email protected]> Date: Thu Jun 13 15:16:47 2024 +1000 merge nightly-testing-2024-06-12 commit a4383ad9adf612ff17e48cb316e2bde7431e41a2 Author: Kim Morrison <[email protected]> Date: Thu Jun 13 14:46:18 2024 +1000 fix norm_num commit da517722c631a3270a5d4e4a75e5ded86db1d291 Author: Kim Morrison <[email protected]> Date: Thu Jun 13 14:36:56 2024 +1000 better commit 2d4bcd9fe73287e61c235bf9c2272169d3c49817 Author: Kim Morrison <[email protected]> Date: Thu Jun 13 14:34:31 2024 +1000 fix commit 406a44de79937a44be6ff0f8557651efdb84fc19 Merge: 368dff52372 616a338e1b2 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 13 03:31:43 2024 +0000 Merge master into nightly-testing commit 6107a90d4b2aacdfe6d37e09f1ac1cbe82dff8bf Author: Kim Morrison <[email protected]> Date: Thu Jun 13 13:05:15 2024 +1000 deprecations commit 368dff5237233eaea9f25183cbb3c8aa0de20fb6 Author: Kim Morrison <[email protected]> Date: Thu Jun 13 12:51:28 2024 +1000 move batteries back to before #839 commit d752c3143ae57f2ebc336d7825024abde197ed96 Author: Kim Morrison <[email protected]> Date: Thu Jun 13 12:24:45 2024 +1000 . commit 995787ebea8399d78ec8074ee1762df399e6803e Author: Kim Morrison <[email protected]> Date: Thu Jun 13 12:06:42 2024 +1000 . commit 92a7c33eeec40b5196b3174cdff7d9cc05fe4b14 Author: Kim Morrison <[email protected]> Date: Thu Jun 13 11:58:45 2024 +1000 fix bad merge commit 851cdf67785835aebe5246dbb06c7c11598215cb Author: leanprover-community-mathlib4-bot <[email protected]> Date: Thu Jun 13 00:45:01 2024 +0000 Merge master into nightly-testing commit b02044b6b6ecc9675f45c2b2ddb546a4a1abdf4c Author: Kim Morrison <[email protected]> Date: Thu Jun 13 10:33:04 2024 +1000 checkpoint commit 4b5b57fb1d2497f344eb515b02e1e42f567b324a Author: Kim Morrison <[email protected]> Date: Thu Jun 13 10:22:39 2024 +1000 increase maxheartbeats commit 48f3d309f06bd43deffcbfc12865b3d345eb8b71 Author: Kim Morrison <[email protected]> Date: Thu Jun 13 09:36:29 2024 +1000 last fix commit fc479ba3ef5cdb98571383c970570ee6d746eba9 Author: Kim Morrison <[email protected]> Date: Thu Jun 13 09:32:27 2024 +1000 fixes for if-then-else simprocs commit 414408bc81336dc2544776bc4519b5f76f80fa9e Merge: 41c4f07ea9e 8a1d254a926 Author: Kim Morrison <[email protected]> Date: Thu Jun 13 09:13:10 2024 +1000 merge lean-pr-testing-4421 commit 41c4f07ea9e54fdc68b4f1ada9a00fb5a5013797 Merge: 8357de4747c dfc711a8075 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 12 21:31:15 2024 +0000 Merge master into nightly-testing commit 8357de4747cf4abe496ea1b54506444c7d722e87 Merge: e8e04f4fe72 9a5f5b6fc35 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 12 18:33:33 2024 +0000 Merge master into nightly-testing commit e8e04f4fe72d629c902c5178713acd6fbe3beba3 Merge: 1986d91f3bf e0e6e30fb64 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 12 15:31:09 2024 +0000 Merge master into nightly-testing commit 1986d91f3bf5c821d868cdfc7c2baec7b155e51b Merge: cce5f748f83 c542c3a12ba Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 12 12:40:22 2024 +0000 Merge master into nightly-testing commit cce5f748f83269ff1c36dd610e1bd7d6ac967351 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 12 10:02:59 2024 +0000 chore: bump to nightly-2024-06-12 commit b302aeb49f891e5401772c78b8d6ef0ba6ae3491 Merge: 877988840a7 b6cab8a4a3f Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 12 09:31:00 2024 +0000 Merge master into nightly-testing commit 877988840a70104933055a61b001838fcabcb595 Merge: 022c467241c 868018d5650 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 12 06:33:51 2024 +0000 Merge master into nightly-testing commit 17efcf9e71afb14e4c827903d757d6e0c03ebbc0 Author: Kim Morrison <[email protected]> Date: Wed Jun 12 16:20:02 2024 +1000 bump commit 022c467241cb5dc5e6ac20def6f7d924c8d24ee3 Author: Kim Morrison <[email protected]> Date: Wed Jun 12 16:16:16 2024 +1000 move back to nightly-testing commit 6155f2d2d818fa1ca6091fe10e749f0a0dd45d2e Author: Kim Morrison <[email protected]> Date: Wed Jun 12 16:02:59 2024 +1000 fixes commit b53a7279afb1f094a06ef987c31b775063abe07e Author: Kim Morrison <[email protected]> Date: Wed Jun 12 15:53:17 2024 +1000 deprecation commit 8e4d5e5d7fdfdcfebc84705042be9c4e605df2bf Author: Kim Morrison <[email protected]> Date: Wed Jun 12 15:52:36 2024 +1000 simpNF warnings commit 22e1049f0a38bedee324e0f5609ebcb4d327beb0 Author: Kim Morrison <[email protected]> Date: Wed Jun 12 14:17:53 2024 +1000 composition commit c481824d7ceade61f1f90a0fe99e432eb2de7bf9 Author: Kim Morrison <[email protected]> Date: Wed Jun 12 13:45:19 2024 +1000 Partrec commit 1f86f6a67ed1241cb8329f99821380d6ec70a35b Author: Kim Morrison <[email protected]> Date: Wed Jun 12 13:43:54 2024 +1000 PeriodicPts commit 88370d7c16875e8a6d59cdd1407ecfd601bfbb5f Merge: 6c4eb9ed785 c97b50a68c4 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 12 03:32:01 2024 +0000 Merge master into nightly-testing commit 0cd8c7a94ecb03a86b657a478551edc2cf192e8f Author: Kim Morrison <[email protected]> Date: Wed Jun 12 13:26:57 2024 +1000 chinese remainder commit e6b91b7a039b335456b42a190ea7e5ff0c2984cb Author: Kim Morrison <[email protected]> Date: Wed Jun 12 13:25:19 2024 +1000 admissibleabsolutevalue commit ae410d73c8bd072d8dc5b8e738c536a2cb13c497 Author: Kim Morrison <[email protected]> Date: Wed Jun 12 13:03:59 2024 +1000 primrec commit 477270d4893a1f7a155f640d676391ea5f4ca55b Author: Kim Morrison <[email protected]> Date: Wed Jun 12 13:00:54 2024 +1000 formPerm commit ee216e04ecd8befd3aa29ef801ac5d5c53ca6d76 Merge: f20cd20c452 2b37c48ad7f Author: Kim Morrison <[email protected]> Date: Wed Jun 12 12:04:45 2024 +1000 merge master commit 6c4eb9ed7856fbf816a67289809bbe54d71dc0ee Author: Kim Morrison <[email protected]> Date: Wed Jun 12 11:16:04 2024 +1000 try out findUnusedHaves commit b5d75c2520da44737982217f3766432dfc5e1d35 Merge: 208ff762c55 d19a0cebe97 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Wed Jun 12 00:45:07 2024 +0000 Merge master into nightly-testing commit 208ff762c552ca833060c9e508ac2f720abed7f8 Merge: 1087e561c6b e16925c9357 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 11 21:31:07 2024 +0000 Merge master into nightly-testing commit 1087e561c6b88589987ab78b607aefdc37c0f217 Merge: 458557282ed 965c7f81663 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 11 18:33:48 2024 +0000 Merge master into nightly-testing commit 8a1d254a926d376ebba0e5f21d96517a2b4009f6 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 11 17:22:33 2024 +0000 Trigger CI for https://github.com/leanprover/lean4/pull/4421 commit 458557282edf503948d66d8370c475b1d9042909 Merge: b0ee1486fa1 bfaec997eb2 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 11 15:31:06 2024 +0000 Merge master into nightly-testing commit f20cd20c45292b3eb039265e63ece04481050026 Author: Kim Morrison <[email protected]> Date: Tue Jun 11 22:09:35 2024 +1000 wip commit 24ecebf0c66118583189c57ef1af477fe4d09a69 Author: Kim Morrison <[email protected]> Date: Tue Jun 11 21:25:13 2024 +1000 fixes commit b0ee1486fa1df4d3d7e5f6fc2ce3f751e24a8282 Merge: 982d9a725f6 f5e5edceb9f Author: Kim Morrison <[email protected]> Date: Tue Jun 11 20:35:47 2024 +1000 merge lean-pr-testing-4408 commit 982d9a725f607edb5cbc79ab755fbc2022b0bb80 Merge: 9ff673e9634 e60e715faa3 Author: Kim Morrison <[email protected]> Date: Tue Jun 11 20:06:20 2024 +1000 merge lean-pr-testing-4385 commit 9ff673e96346a6ec2f4f69e77721c9f4c91b8b74 Author: Kim Morrison <[email protected]> Date: Tue Jun 11 20:05:22 2024 +1000 deprecations commit 7a0d27f605e654f51dfd1fa700b831115aea3f30 Merge: 0dd3b49c641 be7de9a17bd Author: Kim Morrison <[email protected]> Date: Tue Jun 11 20:03:06 2024 +1000 Merge branch 'nightly-testing' of github.com:leanprover-community/mathlib4 into nightly-testing commit 0dd3b49c641cfdec7c7602cef2df29f441407c53 Author: Kim Morrison <[email protected]> Date: Tue Jun 11 20:03:00 2024 +1000 bump toolchain commit be7de9a17bd7049ef1d9d1719731f613ff548eaf Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 11 10:02:47 2024 +0000 chore: bump to nightly-2024-06-11 commit dde42bb5b2f8964e1e96fb4bc9af188d95334c86 Author: Kim Morrison <[email protected]> Date: Tue Jun 11 20:02:43 2024 +1000 bump dependencies commit 301de2a37b433f2ed8bc81ffcce7be4391f10ab7 Merge: 2a55468e80b 303e71911e1 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 11 09:31:02 2024 +0000 Merge master into nightly-testing commit 69c4e129d975baab3ea1a6f715de0cdc93df2cd7 Author: Kim Morrison <[email protected]> Date: Tue Jun 11 17:04:09 2024 +1000 fixes commit 2a55468e80b7ce4422085f4a735597b4bf70546b Merge: 3b21a4a9658 8852c2c9203 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 11 06:33:54 2024 +0000 Merge master into nightly-testing commit c31e660f1ced3258779c82df5302e4e2c5494edd Author: Kim Morrison <[email protected]> Date: Tue Jun 11 15:53:57 2024 +1000 switch toolchain commit c52a9ed041dec5dec82da4341a86e871a403dfad Author: Kim Morrison <[email protected]> Date: Tue Jun 11 15:02:20 2024 +1000 fixes commit 3b21a4a9658897db84f1513a8eb04e2545f086a4 Merge: c192070c5b6 c0f772270fe Author: Kim Morrison <[email protected]> Date: Tue Jun 11 13:30:17 2024 +1000 merge master commit d04d1db4820ae2ea0791566ec878b44960c37f50 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 11 03:10:55 2024 +0000 Trigger CI for https://github.com/leanprover/lean4/pull/4421 commit e60e715faa3b94e5625d6f1a174fe10d1fa5057f Author: Kim Morrison <[email protected]> Date: Tue Jun 11 12:50:11 2024 +1000 more fixes commit 565c8a76630f9ead0188bc2525d54c102677bf30 Author: leanprover-community-mathlib4-bot <[email protected]> Date: Tue Jun 11 01:50:53 2024 +0000 Update lean-toolchain for testing https://github.com/leanprover/lean4/pull/4421 commit f5e5edceb9f5ef74c068bb389f69a4986c3a4521 Author: Kim Morrison <[email protected]> Date: Tue Jun 11 09:36:49 2024 +1000 one last? commit edc3ace0a2773dd5e8f397b66cec8eead6755b8d Author: Kim Morrison <[email protected]> Date: Tue Jun 11 09:30:14 2024 +1000 …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
release-ci
Enable all CI checks for a PR, like is done for releases
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance issue at #4413 is due to our
Fin.sub
definition.Thus, the following runs out of stack space
at the
isDefEq
testFrom the user's perspective, this timeout is unexpected since they are using small numerals, and none of the other
Fin
basic operations (such asFin.add
andFin.mul
) suffer from this problem.This PR implements an inelegant solution for the performance issue. It redefines
Fin.sub
asThis approach is unattractive because it relies on the fact that
Nat.add
is defined using recursion on the second argument.The impact on this repo was small, but we want to evaluate the impact on Mathlib.
closes #4413