feat: upstream BitVec.toFin_ofNat and BitVec.toFin_neg #4298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lemma is morally equivalent to one which is currently in Mathlib and which is proposed to be deleted from mathlib in #13286. It is only morally equivalent, because the Mathlib lemma is stated in terms of a coercion from `Nat` to `Fin (2^w)` which relies on `NeZero` machinery available only in Mathlib
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 28, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 28, 2024
alexkeizer
changed the title
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 28, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 28, 2024
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added
breaks-mathlib
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 28, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lemmas are morally equivalent to Mathlib lemmas which are proposed to be deleted from Mathlib in #13286.
It is only morally equivalent, because the Mathlib lemmas are stated in terms of Mathlib-defined things:
toFin_natCastuses a coercion fromNattoFin (2^w)which relies onNeZeromachinery available only in Mathlib. Thus, I've rephrased the rhs in terms of the def-eqFin.ofNat'with an explicit proof that2^wis non-zero.Similarly, the RHS of
toFin_negwas phrased in terms of negation onFins, which is only defined in Mathlib, so I've unfolded the definition.