-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: lake: cloud release build output fixes & related touchups #4220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
May 19, 2024
Mathlib CI status (docs):
|
tydeu
force-pushed
the
lake/build-refactor-fix
branch
from
May 19, 2024 22:19
47032ce
to
28ac333
Compare
tydeu
changed the title
fix: lake: do not always print caption for release fetch & touchups
chore: lake: cloud releases fixes & related touchups
May 20, 2024
tydeu
changed the title
chore: lake: cloud releases fixes & related touchups
chore: lake: cloud release build output fixes & related touchups
May 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 20, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 20, 2024
Fixes two output bugs with cloud releases: (1) the fetch as part of an `extraDep` was not properly isolated in a job, and (2) the release job would be shown even if the release had already been successfully fetched. Also includes some related touchups, including the addition of show all jobs on `-v` which helps with debugging job counts. (cherry picked from commit 6171070)
tydeu
added a commit
that referenced
this pull request
May 20, 2024
Fixes two output bugs with cloud releases: (1) the fetch as part of an `extraDep` was not properly isolated in a job, and (2) the release job would be shown even if the release had already been successfully fetched. Also includes some related touchups, including the addition of show all jobs on `-v` which helps with debugging job counts. (cherry picked from commit 6171070)
kim-em
pushed a commit
that referenced
this pull request
May 21, 2024
Fixes two output bugs with cloud releases: (1) the fetch as part of an `extraDep` was not properly isolated in a job, and (2) the release job would be shown even if the release had already been successfully fetched. Also includes some related touchups, including the addition of show all jobs on `-v` which helps with debugging job counts. (cherry picked from commit 6171070)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport releases/v4.8.0
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two output bugs with cloud releases: (1) the fetch as part of an
extraDep
was not properly isolated in a job, and (2) the release job would be shown even if the release had already been successfully fetched.Also includes some related touchups, including the addition of show all jobs on
-v
which helps with debugging job counts.