Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lake: cloud release build output fixes & related touchups #4220

Merged
merged 3 commits into from
May 20, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented May 19, 2024

Fixes two output bugs with cloud releases: (1) the fetch as part of an extraDep was not properly isolated in a job, and (2) the release job would be shown even if the release had already been successfully fetched.

Also includes some related touchups, including the addition of show all jobs on -v which helps with debugging job counts.

@tydeu tydeu added this to the v4.8.0-rc2 milestone May 19, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 19, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented May 19, 2024

Mathlib CI status (docs):

  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2024-05-19 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2024-05-19 19:10:07)
  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2024-05-19 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2024-05-20 00:28:40)

@tydeu tydeu force-pushed the lake/build-refactor-fix branch from 47032ce to 28ac333 Compare May 19, 2024 22:19
@tydeu tydeu added this pull request to the merge queue May 19, 2024
@tydeu tydeu removed this pull request from the merge queue due to a manual request May 19, 2024
@tydeu tydeu changed the title fix: lake: do not always print caption for release fetch & touchups chore: lake: cloud releases fixes & related touchups May 20, 2024
@tydeu tydeu changed the title chore: lake: cloud releases fixes & related touchups chore: lake: cloud release build output fixes & related touchups May 20, 2024
@tydeu tydeu added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@tydeu tydeu added the full-ci label May 20, 2024
@tydeu tydeu enabled auto-merge May 20, 2024 02:53
@tydeu tydeu added this pull request to the merge queue May 20, 2024
Merged via the queue into leanprover:master with commit 6171070 May 20, 2024
20 checks passed
github-actions bot pushed a commit that referenced this pull request May 20, 2024
Fixes two output bugs with cloud releases: (1) the fetch as part of an
`extraDep` was not properly isolated in a job, and (2) the release job
would be shown even if the release had already been successfully
fetched.

Also includes some related touchups, including the addition of show all
jobs on `-v` which helps with debugging job counts.

(cherry picked from commit 6171070)
tydeu added a commit that referenced this pull request May 20, 2024
Fixes two output bugs with cloud releases: (1) the fetch as part of an
`extraDep` was not properly isolated in a job, and (2) the release job
would be shown even if the release had already been successfully
fetched.

Also includes some related touchups, including the addition of show all
jobs on `-v` which helps with debugging job counts.

(cherry picked from commit 6171070)
@tydeu tydeu deleted the lake/build-refactor-fix branch May 20, 2024 04:31
kim-em pushed a commit that referenced this pull request May 21, 2024
Fixes two output bugs with cloud releases: (1) the fetch as part of an
`extraDep` was not properly isolated in a job, and (2) the release job
would be shown even if the release had already been successfully
fetched.

Also includes some related touchups, including the addition of show all
jobs on `-v` which helps with debugging job counts.

(cherry picked from commit 6171070)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport releases/v4.8.0 toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants