-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: getLsb_signExtend #4187
Merged
Merged
feat: getLsb_signExtend #4187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkeizer
reviewed
May 16, 2024
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Jun 2, 2024
Mathlib CI status (docs):
|
chore: truncate -> zext, to carry more semantic information. Co-authored-by: Tobias Grosser <[email protected]>
awaiting-review |
kim-em
reviewed
Jun 4, 2024
kim-em
reviewed
Jun 4, 2024
kim-em
reviewed
Jun 4, 2024
kim-em
reviewed
Jun 4, 2024
kim-em
reviewed
Jun 4, 2024
kim-em
added
awaiting-author
Waiting for PR author to address issues
and removed
awaiting-review
Waiting for someone to review the PR
labels
Jun 4, 2024
Close now! |
chore: change comment about msb=false into a sentence. Co-authored-by: Kim Morrison <[email protected]>
tobiasgrosser
approved these changes
Jun 4, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 4, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 4, 2024
awaiting-review |
github-actions
bot
added
awaiting-review
Waiting for someone to review the PR
and removed
awaiting-author
Waiting for PR author to address issues
labels
Jun 4, 2024
@bollu, can you update the commit message accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting-review
Waiting for someone to review the PR
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key idea is to notice that
signExtend
behavior is controlled by themsb
. Whenmsb = false
,sext
behaves the same astrunc
. Whenmsb = true
,sext
behaves liketrunc
but adds high 1-bits. This is expressed using the negate-truncate-negate pattern. Lemma statements below:These give the final theorem statement: