Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: no need for simpMatchWF? #4153

Merged
merged 4 commits into from
May 13, 2024
Merged

refactor: no need for simpMatchWF? #4153

merged 4 commits into from
May 13, 2024

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented May 13, 2024 •
edited
Loading

Despite what it said in its docstring, simpMatchWF? seems to behave like simpMatch?, so let’s just use that.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc May 13, 2024 16:38 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 13, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 13, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4153
3001265
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 13, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4153
3647ccc
@nomeata nomeata marked this pull request as ready for review May 13, 2024 17:09
@nomeata nomeata added the will-merge-soon …unless someone speaks up label May 13, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc May 13, 2024 17:18 Inactive
@leodemoura leodemoura changed the title refactor: no need for simpMatchWF? refactor: no need for simpMatchWF? May 13, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 13, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4153
8b67019
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 13, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4153
579e95c
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label May 13, 2024
@nomeata nomeata added this pull request to the merge queue May 13, 2024
Merged via the queue into master with commit 7c4284a May 13, 2024
19 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nomeata @leanprover-community-mathlib4-bot