Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: lake: error on package name mismatch + std special case #3999

Merged
merged 4 commits into from
Apr 30, 2024
Merged

chore: lake: error on package name mismatch + std special case #3999

merged 4 commits into from
Apr 30, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Apr 27, 2024 •
edited
Loading

Lake now errors instead of warns on a mismatch between a package name and what is required as. This avoids sometimes confusing downstream errors. Also, this change provides additional information for errors that may be caused by the upcoming Std rename.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 27, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 27, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3999
af33379
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 27, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3999
736f61c
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Apr 27, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Apr 27, 2024 •
edited
Loading

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 27, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3999
d92e215
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 27, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3999
17ce827
@tydeu tydeu changed the title chore: lake: error on package name mismatch + std/boost special case chore: lake: error on package name mismatch + std special case Apr 29, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3999
91a39fc
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3999
1a3d527
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3999
32a4e5e
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3999
29f8105
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3999
a8b3ad4
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3999
2154efd
@tydeu tydeu marked this pull request as ready for review April 29, 2024 22:41
@tydeu tydeu added the will-merge-soon …unless someone speaks up label Apr 29, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3999
58c9034
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 29, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3999
fcb5fe8
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan and removed builds-mathlib CI has verified that Mathlib builds against this PR labels Apr 30, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 30, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3999
b60de6f
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 30, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3999
8aac9c4
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Apr 30, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 30, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3999
dc55254
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 30, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3999
ba64ff9
@tydeu tydeu added this pull request to the merge queue Apr 30, 2024
Merged via the queue into leanprover:master with commit a969d27 Apr 30, 2024
33 checks passed
@tydeu tydeu deleted the lake/std-msg branch April 30, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@kim-em kim-em kim-em approved these changes

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tydeu @leanprover-community-mathlib4-bot @eric-wieser @kim-em