Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve isDefEqProj #3977

Merged
merged 2 commits into from
Apr 23, 2024
Merged

fix: improve isDefEqProj #3977

merged 2 commits into from
Apr 23, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Apr 23, 2024 •
edited
Loading

Currently this will fail in two tests, because of changes in #3965.

  • Sometimes we need to add an additional universe annotation, or we get a stuck at solving universe constraint max u ?u =?= u.
  • Sometimes we need to specify arguments that could previously be found by unification.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 23, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 7a076d0bd4240b8db8c383d2f2e85103bf4a268e --onto 62cdb51ed5b9d8487877d5a4adbcd4659d81fc6a. (2024-04-23 11:34:01)

kim-em and others added 2 commits April 23, 2024 09:41
@kim-em @leodemoura
chore: record regressions from #3965
6e02421
@leodemoura
fix: improve isDefEqProj
a6240a9 
The new test `3965_2.lean` shows that `tryHeuristic` is also useful
when solving contraints of the form `t.i =?= s.i`. For example,
suppose we have `(f a).i =?= (f ?u).i`. By using `tryHeuristic`,
we obtain the solution `?u := a` before unfolding `f`.
@leodemoura leodemoura changed the title chore: record regression from leanprover/lean4#3965 fix: improve isDefEqProj Apr 23, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 23, 2024 17:54 Inactive
@leodemoura leodemoura added this pull request to the merge queue Apr 23, 2024
Merged via the queue into master with commit fb135b8 Apr 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kim-em @leanprover-community-mathlib4-bot @leodemoura