Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lake: package duplication in workspace #3957

Merged
merged 2 commits into from
Apr 23, 2024
Merged

fix: lake: package duplication in workspace #3957

merged 2 commits into from
Apr 23, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Apr 20, 2024

Fixes a bug where packages that appeared multiple times in the dependency tree would be duplicated in the workspace (and in manifests). Added a regression test for this to prevent this from happening again in the future.

This was first reported in leanprover/mathlib4#12250.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 20, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Apr 20, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Std CI can not be attempted yet, as the nightly-testing-2024-04-19 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Std CI should run now. (2024-04-20 01:23:22)
  • ✅ Mathlib branch lean-pr-testing-3957 has successfully built against this PR. (2024-04-22 16:43:53) View Log
  • ✅ Mathlib branch lean-pr-testing-3957 has successfully built against this PR. (2024-04-22 17:27:07) View Log
  • ✅ Mathlib branch lean-pr-testing-3957 has successfully built against this PR. (2024-04-23 04:28:00) View Log

@tydeu tydeu marked this pull request as ready for review April 20, 2024 03:05
kim-em
kim-em approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@kim-em kim-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd like to have this in by v4.8.0-rc1.

@tydeu tydeu force-pushed the lake/fix-pkg-dup branch from 96d0be5 to 8959842 Compare April 22, 2024 15:12
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 22, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3957
4ed1fee
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 22, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3957
d6d47bb
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Apr 22, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 22, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3957
6d635ed
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 22, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3957
d73c5d5
@tydeu tydeu added this pull request to the merge queue Apr 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 22, 2024
@kim-em kim-em added the full-ci label Apr 23, 2024
@kim-em
Copy link
Collaborator

kim-em commented Apr 23, 2024

Haven't seen that failure before! Adding full-ci to help debug.

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 23, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3957
a86b022
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 23, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3957
83547c3
@Kha
Copy link
Member

Kha commented Apr 23, 2024

Hopefully just a broken GitHub machine

@Kha Kha added this pull request to the merge queue Apr 23, 2024
Merged via the queue into leanprover:master with commit 7a076d0 Apr 23, 2024
34 checks passed
@tydeu tydeu deleted the lake/fix-pkg-dup branch April 23, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em kim-em approved these changes

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tydeu @leanprover-community-mathlib4-bot @kim-em @Kha