Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make deriving handler for Repr be consistent about erasing types and proofs #3944

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: make deriving handler for Repr be consistent about erasing types and proofs #3944

merged 1 commit into from
May 8, 2024

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Apr 18, 2024

The deriving handler would use _ for types and proofs for structures but not for inductives.

Reported by Graham Leach-Krouse on Zulip.

@kmill kmill requested a review from kim-em as a code owner April 18, 2024 17:47
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 18, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Apr 18, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b6d77be6a5ced7cbd7b6e051047158e7e07bee4e --onto d3e004932c1f5ac3946850692940512d381c7634. (2024-04-18 18:04:58)
  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase b6d77be6a5ced7cbd7b6e051047158e7e07bee4e --onto 62cdb51ed5b9d8487877d5a4adbcd4659d81fc6a. (2024-04-22 07:11:22)
  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 35d9307df30c1cbd2ab1103e083c21dd70dbd191 --onto e362b50fa95d6823e59dd706803a93c25e888535. (2024-05-06 13:27:57)

@kim-em kim-em added the will-merge-soon …unless someone speaks up label Apr 22, 2024
@kmill
fix: make deriving handler for Repr be consistent about erasing typ…
a4d7329 
…es and proofs

The deriving handler would use `_` for types and proofs for structures but not for inductives.

Reported by Graham Leach-Krouse on [Zulip](https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/Deriving.20Repr.20for.20an.20inductive.20with.20proof.20parameters/near/434181985).
@kmill kmill force-pushed the derive_repr_proof branch from 4a0757f to a4d7329 Compare May 6, 2024 13:10
@kim-em kim-em added this pull request to the merge queue May 7, 2024
Merged via the queue into leanprover:master with commit a257767 May 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmill @leanprover-community-mathlib4-bot @eric-wieser @kim-em