fix: semantic tokens performance #3932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
mhuisi
force-pushed
the
mhuisi/semantic-highlighting-perf
branch
from
c2fc7d4 to
869325a
Compare
Kha
approved these changes
Apr 17, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 17, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 17, 2024
leanprover-community-mathlib4-bot
added
the
builds-mathlib
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 17, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing #3925, I noticed that the performance of the
textDocument/semanticTokens/fullrequest is extremely bad due to a quadratic implementation. Specifically, on my machine, computing the full semantic tokens forLean/Elab/Do.leantook a full 5s. In practice, this means that while elaborating the file, one core is entirely busy with computing the semantic tokens for the file.This PR fixes this performance bug by re-implementing the semantic token handling, reducing the latency for
Lean/Elab/Do.leanfrom 5s to 60ms. As a result, the overly cautious refresh latency of 5s in #3925 can easily be reduced to 2s again.Since the previous semantic tokens implementation used a very brittle hack to identify projections, this PR also changes the projection notation elaboration to augment the
InfoTreesyntax for the field of a projection with a special syntax node of kindLean.Parser.Term.identProjKind. With this syntax kind, projection fields can now easily be identified in theInfoTree.