Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: docstrings on binder types, make sure hovers work #3917

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Apr 15, 2024

Moved ppGroup inside the leading_parsers for all the binder types so that hovering works. Improved the docstrings.

Moved `ppGroup` inside the `leading_parser`s for all the binder types so that hovering works. Improved the docstrings.
@kmill kmill added the documentation Documentation improvement label Apr 15, 2024
@kmill kmill requested a review from Kha as a code owner April 15, 2024 21:24
Copy link
Collaborator

@nomeata nomeata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docstrings, very helpful already!

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 15, 2024
@kmill kmill added this pull request to the merge queue Apr 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2024
@kmill kmill added this pull request to the merge queue Apr 17, 2024
Merged via the queue into leanprover:master with commit 89558a0 Apr 17, 2024
11 of 17 checks passed
@kmill kmill deleted the binder_hover_docstrings branch April 17, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation improvement toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants