chore: remove @ from rw? suggestions, and enable hover on constants in #check #3911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 15, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 15, 2024
digama0
approved these changes
Apr 15, 2024
leanprover-community-mathlib4-bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 15, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 15, 2024
|
There will be some downstream breakage, but should be minor so I'm not going to fix ahead of time. |
kmill
reviewed
Apr 15, 2024
There was a problem hiding this comment.
In the PR message:
improving the hover behaviour in #check.
Could you mention what's being improved in the PR message? I seem to be able to hover over everything except for the constant itself, so I'm guessing it's that this lets you hover over the constant? That makes some sense, for being able to see the docstring, even if you don't need to see the type.
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 16, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 16, 2024
kmill
added a commit
to kmill/lean4
that referenced
this pull request
Jul 5, 2024
In leanprover#3911, a refactor to share `MessageData` code between `ppConst` and the signature pretty printer unintentionally caused the signature pretty printer to use the `pp.tagAppFns` option. This causes, for example, `+` in `a + b` to independently have its own hover information. This affects `#check` and was reported by Kevin Buzzard [on Zulip](https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/degraded.20hover.20experience.20on.20.23check/near/449380674).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
In #3911, a refactor to share `MessageData` code between `ppConst` and the signature pretty printer unintentionally caused the signature pretty printer to use the `pp.tagAppFns` option. This causes, for example, `+` in `a + b` to independently have its own hover information due to the fact that `notation` app unexpanders use the head function's syntax as the `ref` when constructing the notation syntax. This behavior of `pp.tagAppFns` is intentional, and it is used by docgen, but it should not be activated for signatures. This affects `#check` and was reported by Kevin Buzzard [on Zulip](https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/degraded.20hover.20experience.20on.20.23check/near/449380674). This PR also makes sure the initial `ref` when applying app unexpanders is `.missing`, rather than whatever random value might be present in the `CoreM` context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the unused
Lean.PrettyPrinter.ppConstwithMessageData.ofConst(which similarly avoids an unnecessary@) and that further generates a hover for the constantUses this in
TryThis.addRewriteSuggestion, so thatrw?suggestions don't have unnecessary@s.Add
MessageData.signature, as a wrapper aroundPrettyPrinter.signature, using the same machinery to generate hovers for constants, improving the hover behaviour in #check so that we get second order pop-up for constants in the signature. (Not sure how to write tests for second order hovers, so there is no test for this.)