Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update norm_cast and push_cast documentation #3908

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Apr 14, 2024

No description provided.

@kmill kmill added documentation Documentation improvement awaiting-review Waiting for someone to review the PR labels Apr 14, 2024
@kmill
Copy link
Collaborator Author

kmill commented Apr 14, 2024

@david-christiansen This could be improved more still, but my primary goal was just "let's make it not wrong" and do a handful of incremental improvements on top of that.

An obvious question for future improvements is answering "what's a cast exactly?" I don't know the answer, beyond "it's a coercion that these tactics have any cast lemmas about".

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 14, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2024-04-14 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2024-04-14 19:14:11)

src/Init/Tactics.lean Outdated Show resolved Hide resolved
Co-authored-by: Mario Carneiro <[email protected]>
@kim-em
Copy link
Collaborator

kim-em commented Apr 22, 2024

Better than what we had, so let's merge.

@kim-em kim-em added this pull request to the merge queue Apr 22, 2024
Merged via the queue into leanprover:master with commit 46f42cc Apr 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Waiting for someone to review the PR documentation Documentation improvement toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants