Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: fix linearity issue in insertIfNew #3881

Merged
merged 1 commit into from
Apr 11, 2024
Merged

perf: fix linearity issue in insertIfNew #3881

merged 1 commit into from
Apr 11, 2024

Conversation

hargoniX
Copy link
Contributor

This fixes a linearity isssue in insertIfNew. As insertIfNew is used in Lean.finalizeImport we expect this to improve performance.

@hargoniX
Copy link
Contributor Author

!bench

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 11, 2024 12:48 Inactive
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit faab75b.
There were significant changes against commit 68e3982:

  Benchmark     Metric             Change
  ==================================================
+ import Lean   branch-misses       -1.7%  (-10.3 σ)
+ stdlib        tactic execution    -1.9% (-242.2 σ)

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 11, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 11, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3881
68fc10a
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 11, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3881
fe538ce
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Apr 11, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Apr 11, 2024 •
edited
Loading

Mathlib CI status (docs):

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 11, 2024 14:12 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 11, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3881
bfe937c
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 11, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3881
f506347
@hargoniX hargoniX added this pull request to the merge queue Apr 11, 2024
Merged via the queue into master with commit 3ed2d9b Apr 11, 2024
19 checks passed
@eric-wieser eric-wieser mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hargoniX @leanprover-bot @leanprover-community-mathlib4-bot