Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make generalized field notation for abbreviation types handle optional parameters #3746

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix: make generalized field notation for abbreviation types handle optional parameters #3746

merged 1 commit into from
Mar 28, 2024

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Mar 23, 2024

Closes #3745

@kmill kmill added the awaiting-review Waiting for someone to review the PR label Mar 23, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 23, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 8ce98e62ac82379caaa4e76243e8f4ac3fccf366 --onto d5a1dce0ae92475c73a9c24fc8fb2c8e0d4acbcd. (2024-03-23 04:02:38)

nomeata
nomeata approved these changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@nomeata nomeata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kim-em kim-em added this pull request to the merge queue Mar 28, 2024
Merged via the queue into leanprover:master with commit 520cd3f Mar 28, 2024
11 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomeata nomeata nomeata approved these changes

Assignees
No one assigned
Labels
awaiting-review Waiting for someone to review the PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Field notation for abbreviations fails if the argument is an optParam
4 participants
@kmill @leanprover-community-mathlib4-bot @nomeata @kim-em