Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct module name in references #3722

Merged
merged 1 commit into from
Mar 20, 2024
Merged

fix: use correct module name in references #3722

merged 1 commit into from
Mar 20, 2024

Conversation

mhuisi
Copy link
Contributor

@mhuisi mhuisi commented Mar 20, 2024

#3656 used the wrong name in RefIdent, which lead to "Find References" being broken. I really need to set up some tests for this functionality ...

@mhuisi mhuisi added this pull request to the merge queue Mar 20, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 20, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase afbf8759e11acc1a224e42f92557f5697e4691f0 --onto 3ab1c23500658a1997b342fad15f499d7c482365. (2024-03-20 17:09:36)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2024
@mhuisi mhuisi added this pull request to the merge queue Mar 20, 2024
Merged via the queue into leanprover:master with commit 40b5282 Mar 20, 2024
10 checks passed
Kha pushed a commit to Kha/lean4 that referenced this pull request Mar 25, 2024
@mhuisi @Kha
fix: use correct module name in references (leanprover#3722)
793188e 
leanprover#3656 used the wrong name in `RefIdent`, which lead to "Find References"
being broken. I really need to set up some tests for this functionality
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhuisi @leanprover-community-mathlib4-bot