Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: test results as job summary #3715

Merged
merged 21 commits into from
Mar 27, 2024
Merged

chore: test results as job summary #3715

merged 21 commits into from
Mar 27, 2024

Conversation

Kha
Copy link
Member

@Kha Kha commented Mar 19, 2024

Tired of scrolling through and parsing the test output myself

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 19, 2024 10:19 Inactive
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 19, 2024 11:09 Inactive
@Kha Kha added the full-ci label Mar 19, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 19, 2024 11:12 Inactive
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 19, 2024 12:57 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 19, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 19, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3715
280fdb5
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 19, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3715
ad90cdb
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Mar 19, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Mar 19, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ✅ Mathlib branch lean-pr-testing-3715 has successfully built against this PR. (2024-03-19 14:46:39) View Log
  • ✅ Mathlib branch lean-pr-testing-3715 has successfully built against this PR. (2024-03-19 15:53:13) View Log
  • 🟡 Mathlib branch lean-pr-testing-3715 build against this PR was cancelled. (2024-03-20 13:54:16) View Log
  • ✅ Mathlib branch lean-pr-testing-3715 has successfully built against this PR. (2024-03-20 15:01:04) View Log
  • 🟡 Mathlib branch lean-pr-testing-3715 build this PR didn't complete normally. (2024-03-21 13:44:42) View Log
  • ✅ Mathlib branch lean-pr-testing-3715 has successfully built against this PR. (2024-03-21 14:51:41) View Log
  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 466ef74ccc024e334e9c78d9e008d3f7612f9ccf --onto 4c0106d757d4d6d3b7f3903611ce22100d539d2a. (2024-03-26 17:26:42)

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 19, 2024 14:48 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 19, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3715
f0d4e21
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 19, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3715
0500555
@Kha Kha removed the full-ci label Mar 20, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 20, 2024 12:53 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 20, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3715
f76442c
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 20, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3715
e1c9130
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 20, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3715
17a6f0b
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 20, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3715
626df5f
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 21, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3715
2fa6901
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 21, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3715
9e02289
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 21, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3715
0cd886d
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 21, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3715
fd8342e
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 26, 2024 17:31 Inactive
@Kha
Copy link
Member Author

Kha commented Mar 27, 2024

@nomeata It does now list the failing tests but actually showing the stdout output would require some ctest-specific changes to the action

image

@nomeata
Copy link
Collaborator

nomeata commented Mar 27, 2024

Well, it is an improvement, so merge and maybe iterate there?

We could additionally configure ctest to not print successful tests in the build log. Advantage: Errors are easier to find. Downside: no progress indication when looking at live logs.

@Kha
Copy link
Member Author

Kha commented Mar 27, 2024

Well, it is an improvement, so merge and maybe iterate there?

Agreed

We could additionally configure ctest to not print successful tests in the build log. Advantage: Errors are easier to find. Downside: no progress indication when looking at live logs.

Too bad --progress doesn't seem to work in Actions

@Kha Kha marked this pull request as ready for review March 27, 2024 10:13
@Kha Kha requested a review from kim-em as a code owner March 27, 2024 10:13
@Kha Kha added this pull request to the merge queue Mar 27, 2024
Merged via the queue into master with commit 16fdca1 Mar 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kha @leanprover-community-mathlib4-bot @nomeata