Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add inductive.autoPromoteIndices option #3590

Merged
merged 1 commit into from
Apr 22, 2024
Merged

feat: add inductive.autoPromoteIndices option #3590

merged 1 commit into from
Apr 22, 2024

Conversation

arthur-adjedj
Copy link
Contributor

@arthur-adjedj arthur-adjedj commented Mar 4, 2024 •
edited
Loading

This PR partly addresses #3458, by adding an option autoPromoteIndices to turn off the promotion of fixed indices to parameters. The actual fix for the issue is in a separate PR #3591.

Because nested inductive datatypes parameters cannot contain local variables, it is often desirable for a fixed index to not be promoted, as to allow free variables in that place. See example in 3458_1.lean

@arthur-adjedj arthur-adjedj mentioned this pull request Mar 4, 2024
Merged
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 4, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 4, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3590
0975964
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 4, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3590
0623bcd
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Mar 4, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Mar 4, 2024 •
edited
Loading

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 4, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3590
89fcb06
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 4, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3590
237d492
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 4, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3590
9871983
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 4, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3590
0e26f44
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 4, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3590
d06b05b
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 4, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3590
f4708b0
@arthur-adjedj arthur-adjedj changed the title feat: add autoPromoteIndices option feat: add inductive.autoPromoteIndices option Mar 4, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Mar 4, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3590
1e60a37
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Mar 4, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#3590
75e3011
@arthur-adjedj arthur-adjedj marked this pull request as ready for review March 6, 2024 23:21
@arthur-adjedj
Copy link
Contributor Author

awaiting-review

@github-actions github-actions bot added the awaiting-review Waiting for someone to review the PR label Mar 6, 2024
@kim-em kim-em added this pull request to the merge queue Apr 22, 2024
Merged via the queue into leanprover:master with commit 6ad28ca Apr 22, 2024
13 checks passed
github-merge-queue bot pushed a commit that referenced this pull request May 6, 2024
@arthur-adjedj
fix: Incorrect promotion from index to paramater (#3591)
1ea92ba 
Depends on #3590

Closes #3458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting-review Waiting for someone to review the PR builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthur-adjedj @leanprover-community-mathlib4-bot @kim-em