-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lake update
from unsupported manifest versions
#3149
Conversation
One design consideration here is whether this should be done on all |
|
I think I'd personally prefer the more conservative behaviour (only start over on a bare But I don't think it's critical, this is a rare enough corner case. |
@semorrison Thanks for the input! I was really unsure myself, so I really appreciate it. I think you are right. The current behavior defaults an invalid manifest |
If the current manifest is from unsupported (or has errors), a bare
lake update
will now discard it and create a new one from scratch rather than erroring and requiring you to manually delete the manifest. Lake will produce warnings noting it is ignoring such invalid manifests.