Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pr-release: Also work with older tags #3097

Merged
merged 2 commits into from
Dec 20, 2023
Merged

chore: pr-release: Also work with older tags #3097

merged 2 commits into from
Dec 20, 2023

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Dec 20, 2023

No description provided.

@nomeata nomeata requested review from Kha and kim-em as code owners December 20, 2023 08:43
@nomeata nomeata mentioned this pull request Dec 20, 2023
Closed
@nomeata nomeata force-pushed the joachim/pr-release-tags branch from bcbf67f to 6367bea Compare December 20, 2023 08:45
@nomeata
Copy link
Collaborator Author

nomeata commented Dec 20, 2023

Here it seemed to have worked: https://github.com/nomeata/lean4/actions/runs/7273013507/job/19816172222

Most recent nightly: 2023-12-04
SHA of most recent nightly: 14296ae720a97985eb35db35818d66c5ec75d63a
SHA of merge-base: 14296ae720a97985eb35db35818d66c5ec75d63a
Most recent nightly tag agrees with the merge base.
... and Mathlib has a 'nightly-testing-2023-12-04' branch.

@nomeata nomeata added the awaiting-review Waiting for someone to review the PR label Dec 20, 2023
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 20, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

  • ❗ Mathlib CI can not be attempted yet, as the 'nightly-testing-2023-12-20' branch does not exist there yet. We will retry when you push more commits. It may be necessary to rebase onto 'nightly' tomorrow. (2023-12-20 09:14:44)

@kim-em kim-em added this pull request to the merge queue Dec 20, 2023
@nomeata nomeata mentioned this pull request Dec 20, 2023
Merged
@nomeata nomeata removed the awaiting-review Waiting for someone to review the PR label Dec 20, 2023
Merged via the queue into master with commit 79c7b27 Dec 20, 2023
7 checks passed
@nomeata nomeata deleted the joachim/pr-release-tags branch December 20, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em kim-em approved these changes

@Kha Kha Awaiting requested review from Kha

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nomeata @leanprover-community-mathlib4-bot @kim-em