chore: robustify PR release workflow #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomeata
force-pushed
the
joachim/fix-pr-release
branch
from
83f0760 to
e776021
Compare
the workflow is triggered not only by pull-request-CI-runs but also by others. These should be skipped. Also, no need to query the Github API to get the pull request number and head sha, they are part of the payload, it seems.
nomeata
force-pushed
the
joachim/fix-pr-release
branch
from
e776021 to
e4b28e8
Compare
github-actions
bot
added
the
toolchain-available
|
|
If they are part of the payload, can't we directly access them in |
|
Yes, but it makes the |
|
Ok, fine with me |
Kha
reviewed
Dec 12, 2023
| }) | ||
| core.setOutput('pullRequestNumber', reply.data.pull_requests[0].number) | ||
| core.setOutput('sourceHeadSha', reply.data.pull_requests[0].head.sha) | ||
| // console.log(`context.payload: ${JSON.stringify(context.payload, null, 2)}`) |
There was a problem hiding this comment.
Yes, it's useful for debugging to not have to look it up everytime :-)
(unless you mind)
|
Not robust enough, it seems :-( https://github.com/leanprover/lean4/actions/runs/7187252254/job/19574429098 |
|
classic undefined behavior |
|
Should have left the debugging output on :-) But that was this odd very old PR that got activated, maybe that played a role. I'll keep an eye open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the workflow is triggered not only by pull-request-CI-runs but also by
others. These should be skipped.
Also, no need to query the Github API to get the pull request number and
head sha, they are part of the payload, it seems.