Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: lake: simplify math template & test it #2930

Merged
merged 2 commits into from
Nov 27, 2023
Merged

refactor: lake: simplify math template & test it #2930

merged 2 commits into from
Nov 27, 2023

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Nov 20, 2023 •
edited
Loading

Removes the CI option from the math template. Since the template does not currently generate a GitHub workflow, it does not do anything out of the box except add unnecessary complexity.

The math template is also now tested in tests/init (minus the Mathlib require).

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 21, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Nov 21, 2023 •
edited
Loading

  • ❗ Mathlib CI will not be attempted unless you rebase your PR onto the 'nightly' branch. (2023-11-21 00:54:08)
  • ✅ Mathlib branch lean-pr-testing-2930 has successfully built against this PR. (2023-11-21 21:34:41) View Log
  • ✅ Mathlib branch lean-pr-testing-2930 has successfully built against this PR. (2023-11-27 19:46:56) View Log

leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 21, 2023
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#2930
40fa9c2
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Nov 21, 2023
@tydeu tydeu added the will-merge-soon …unless someone speaks up label Nov 21, 2023
@tydeu tydeu mentioned this pull request Nov 21, 2023
Merged
@tydeu
Copy link
Member Author

tydeu commented Nov 21, 2023

@semorrison Any comments? As our math community specialist, it seems appropriate to notify you of this PR before I merge.

kim-em
kim-em approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@kim-em kim-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tydeu tydeu force-pushed the lake/simp-math-tmpl branch from 2d870a6 to a1a5ef7 Compare November 27, 2023 17:09
@tydeu tydeu force-pushed the lake/simp-math-tmpl branch from a1a5ef7 to cafd0a4 Compare November 27, 2023 17:15
@tydeu tydeu enabled auto-merge November 27, 2023 17:17
@tydeu tydeu added this pull request to the merge queue Nov 27, 2023
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 27, 2023
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#2930
62bfe76
Merged via the queue into leanprover:master with commit c20d657 Nov 27, 2023
16 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Nov 27, 2023
@tydeu
doc: release notes for recent lake changes (#2938)
190ac50 
Release notes for PRs #2928, #2930, #2932, and #2937.
@tydeu tydeu deleted the lake/simp-math-tmpl branch December 21, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 digama0 left review comments

@kim-em kim-em kim-em approved these changes

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tydeu @leanprover-community-mathlib4-bot @kim-em @digama0