feat: bare lake init & validated pkg names
#2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tydeu
force-pushed
the
lake/init-pkg-names
branch
from
f78b7f1 to
2cb12ec
Compare
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 16, 2023
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
kim-em
reviewed
Nov 16, 2023
Comment on lines
+236
to
+240
| def validatePkgName (pkgName : String) : LogIO PUnit := do | ||
| if pkgName.isEmpty || pkgName.all (· == '.') || pkgName.any (· ∈ ['/', '\\']) then | ||
| error "illegal package name" | ||
| if pkgName.toLower ∈ ["init", "lean", "lake", "main"] then | ||
| error "reserved package name" |
There was a problem hiding this comment.
I am tempted to say "some validation is better than none, but couldn't we restrict to [0-9A-Za-z-_]*?, but won't. :-)
There was a problem hiding this comment.
@semorrison My current reason for avoiding this is twofold. We might wish to permit non-English or Mathematical characters in package names for broader appeal. Second, this validation currently only applies to the init/new not to the package declaration itself, so any rules here can currently be circumvented. In the future, though, have a more restricted subset for package names in general would likely be a good idea.
kim-em
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2637.
As a new feature,
lake init .or a barelake initwill now create a package with the current directory's name.Will also validate that a package name:
Init,Lean,Lake, orMain(case-insensitive).or all whitespace/or\.