refactor: lake: more flexible manifest #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tydeu
force-pushed
the
lake/flexible-manifest
branch
2 times, most recently
from
222f08e to
2bdbb46
Compare
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 2, 2023
tydeu
force-pushed
the
lake/flexible-manifest
branch
from
2bdbb46 to
4a5b2b8
Compare
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
|
!bench |
|
Here are the benchmark results for commit 4a5b2b8. |
tydeu
force-pushed
the
lake/flexible-manifest
branch
from
4a5b2b8 to
65627d4
Compare
tydeu
force-pushed
the
lake/flexible-manifest
branch
from
65627d4 to
9b1999b
Compare
tydeu
force-pushed
the
lake/flexible-manifest
branch
from
9b1999b to
8d32ed4
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored manifest code to make it easier to mdodify the its format across future versions while mataining backwards compatibility.
For actual format changes: removed
optsand addedconfigFileandmanifestFileto the package entry. Options can be platform-specific are already locked via the configuration olean. Duplication here is unnecessary and possibly incorrect. Adding the paths for the configuraiton and manifest makes it possible to find them in the future should the defaults change (enabling backwards compatibility).Deprecated the
manifestFilepackage configuration option. This creates complications should we ever wish to load the manifest prior to the package configuration.