Cancel outstanding tasks on document edit in the language server #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kha
commented
Oct 10, 2023
Comment on lines
-149
to
-161
| inductive KernelException | ||
| 0 | unknownConstant (env : Environment) (name : Name) | ||
| 1 | alreadyDeclared (env : Environment) (name : Name) | ||
| 2 | declTypeMismatch (env : Environment) (decl : Declaration) (givenType : Expr) | ||
| 3 | declHasMVars (env : Environment) (name : Name) (expr : Expr) | ||
| 4 | declHasFVars (env : Environment) (name : Name) (expr : Expr) | ||
| 5 | funExpected (env : Environment) (lctx : LocalContext) (expr : Expr) | ||
| 6 | typeExpected (env : Environment) (lctx : LocalContext) (expr : Expr) | ||
| 7 | letTypeMismatch (env : Environment) (lctx : LocalContext) (name : Name) (givenType : Expr) (expectedType : Expr) | ||
| 8 | exprTypeMismatch (env : Environment) (lctx : LocalContext) (expr : Expr) (expectedType : Expr) | ||
| 9 | appTypeMismatch (env : Environment) (lctx : LocalContext) (app : Expr) (funType : Expr) (argType : Expr) | ||
| 10 | invalidProj (env : Environment) (lctx : LocalContext) (proj : Expr) | ||
| 11 | other (msg : String) |
There was a problem hiding this comment.
This listing was outdated and is replicated below
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 12, 2023
leanprover-community-mathlib4-bot
added
the
breaks-mathlib
|
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 12, 2023
Amazingly, the extra result allocation seems to have triggered a mathlib heartbeat timeout
|
!bench |
|
Here are the benchmark results for commit 61b2bfa. |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 12, 2023
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 12, 2023
leanprover-community-mathlib4-bot
added
builds-mathlib
|
@Kha This was reverted due to crashes, and I have a worker stack trace at https://gist.github.com/collares/ae3a8d5b5f7c6976b8d46b5bfb6e945b (commit d15a0a4, Debug). It seems like the kernel calls lean4/src/kernel/for_each_fn.cpp Lines 65 to 66 in d15a0a4 |
|
FWIW, #2036 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dramatically reduces system load and increases responsiveness of the language server. In my tests, I was not able to get the server above 100% CPU anymore.
The
check_systemcalls inside pure Lean functions are a bit problematic. I did not find any process terminations from cancellation anymore after blacklisting two of them in the last commit but I may have missed some of them.