Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: withAssignableSyntheticOpaque in assumption #2596

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Sep 27, 2023

@kim-em kim-em added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Sep 27, 2023
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 27, 2023
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 27, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Sep 27, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

@kim-em kim-em added missing tests This PR requires the addition of tests before it can be merged. and removed awaiting-mathlib We should not merge this until we have a successful Mathlib build labels Sep 27, 2023
@kmill
Copy link
Collaborator

kmill commented Oct 30, 2023

I don't have permission to push to this branch, but here's a test for tests/lean/2361.lean:

import Lean

-- This worked before issue #2361
example {α : Type} {P : α → Prop} (a : α) (h : P a) : ∃ x, P x := by
  constructor
  assumption

example {α : Type} {P : α → Prop} (a : α) (h : P a) : ∃ x, P x := by
  refine ⟨?m, ?c⟩
  -- `?m` is synthetic opaque, so `assumption` needs to be able to assign such metavariables
  -- for this to succeed.
  case c => assumption

example {α : Type} {P : α → Prop} (a : α) (h : P a) : ∃ x, P x := by
  refine' ⟨_, ?c⟩
  case c => assumption

@kim-em kim-em added awaiting-review Waiting for someone to review the PR and removed missing tests This PR requires the addition of tests before it can be merged. labels Oct 30, 2023
@kim-em kim-em marked this pull request as ready for review October 30, 2023 02:52
@kim-em kim-em enabled auto-merge (squash) October 30, 2023 03:03
@kim-em kim-em merged commit 7286dfa into master Oct 30, 2023
14 of 15 checks passed
Komyyy pushed a commit to Komyyy/lean4 that referenced this pull request Nov 2, 2023
* feat: withAssignableSyntheticOpaque in assumption
* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Waiting for someone to review the PR builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing withAssignableSyntheticOpaque for assumption tactic?
3 participants