rename_i renames implementation detail hypotheses

[JLimperg]

Prerequisites

Please put an X between the brackets as you perform the following steps:

• Check that your issue is not already filed:
  https://github.com/leanprover/lean4/issues
• Reduce the issue to a minimal, self-contained, reproducible test case.
  Avoid dependencies to Mathlib or Batteries.
• Test your test case against the latest nightly release, for example on
  https://live.lean-lang.org/#project=lean-nightly
  (You can also use the settings there to switch to “Lean nightly”)

Description

rename_i does not ignore implementation detail hypotheses.

Steps to Reproduce

MWE:

class Foo where

class Bar extends Foo where
  bar : True

def foo : Foo := {}

example [Bar] : Bar := {
  foo with bar := by {
    rename_i inst
    guard_hyp inst : Bar
    /-
    hypothesis inst has type
      Foo
    not
      Bar
    -/
  }

Apologies for the somewhat complex MWE. It's just to set up a goal with an implementation detail hypothesis (namely __src, which appears because of the extended structure).

Versions

"4.12.0-nightly-2024-08-26"

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.