Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Archive/Imo): formalize IMO 1961q3 #9883

Closed
wants to merge 12 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 21, 2024

@urkud urkud marked this pull request as ready for review January 21, 2024 03:14
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jan 21, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) labels Jan 31, 2024
@urkud urkud added please-adopt Inactive PR (would be valuable to adopt) and removed please-adopt Inactive PR (would be valuable to adopt) labels Feb 2, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 2, 2024
@grunweg
Copy link
Collaborator

grunweg commented Feb 6, 2024

Is this PR ready for review?

@urkud
Copy link
Member Author

urkud commented Feb 7, 2024

Some docs are missing and I have no time to write them.

@fpvandoorn fpvandoorn added awaiting-author A reviewer has asked the author a question or requested changes please-adopt Inactive PR (would be valuable to adopt) labels Apr 5, 2024
Copy link

github-actions bot commented Aug 15, 2024

PR summary 7cd26f3f6d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Imo1961Q3
+ abs_cos_int_mul_pi

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@joneugster
Copy link
Collaborator

It appears to me that this PR is in a reasonably good shape and it would be more desirable to have it in Archive as-is instead of waiting for more documentation (it's also not clear to me what documentation is supposedly missing). I suggest

maintainer merge

@joneugster joneugster removed awaiting-author A reviewer has asked the author a question or requested changes please-adopt Inactive PR (would be valuable to adopt) labels Aug 15, 2024
Copy link

🚀 Pull request has been placed on the maintainer queue by joneugster.

@sgouezel
Copy link
Contributor

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 21, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 21, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 21, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Archive/Imo): formalize IMO 1961q3 [Merged by Bors] - feat(Archive/Imo): formalize IMO 1961q3 Aug 21, 2024
@mathlib-bors mathlib-bors bot closed this Aug 21, 2024
@mathlib-bors mathlib-bors bot deleted the YK-imo1961-q3 branch August 21, 2024 11:47
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants