[Merged by Bors] - doc(Geometry/Manifold/LieGroup): extend and clean up docstrings #9766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
grunweg
commented
Jan 15, 2024
•
grunweg
commented
- tweak section names; add comments explaining what's in them
- add two lemma docstrings
- revamp the module docstring to mention all results
- in the module docstring, separate main definitions and results
|
@grunweg yes, please remove the autoImplicit commit so that these PRs can just be handled separately, especially since neither one has a |
j-loreaux
added
awaiting-author
grunweg
force-pushed
the
MR-Liegroup-cleanup
branch
from
b031111 to
ff339e4
Compare
|
awaiting-review |
github-actions
bot
added
awaiting-review
and removed
awaiting-author
1 task
j-loreaux
added
awaiting-author
|
Please also update the PR description (and title if relevant) |
|
Thanks for the fast review! I just incorporated all comments and also pushed two more commits tweaking the docs further. |
github-actions
bot
added
awaiting-review
and removed
awaiting-author
grunweg
changed the title
1 task
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
- tweak section names; add comments explaining what's in them - add two lemma docstrings - revamp the module docstring to mention all results - in the module docstring, separate main definitions and results
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.