Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - style(SetTheory): remove useless parentheses #8279

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Nov 9, 2023

These were caused by a bad notation precedence in mathlib3, where the local version of ^ was given precedence 0. We're not using the local notation at all in Mathlib4 (partly because it was broken, which this PR fixes).


Open in Gitpod

Cleaning up this file now makes it easier to deal with fallout from attempts to fix leanprover/lean4#2220

These were caused by a bad notation precedence in mathlib3, where the local version of `^` was given precedence 0.
We're not using the local notation at all in Mathlib4 (partly because it was broken, which this PR fixes).
@j-loreaux
Copy link
Collaborator

This is a nice fix, thanks!

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Nov 9, 2023
These were caused by a bad notation precedence in mathlib3, where the local version of `^` was given precedence 0. We're not using the local notation at all in Mathlib4 (partly because it was broken, which this PR fixes).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 9, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title style(SetTheory): remove useless parentheses [Merged by Bors] - style(SetTheory): remove useless parentheses Nov 9, 2023
@mathlib-bors mathlib-bors bot closed this Nov 9, 2023
@mathlib-bors mathlib-bors bot deleted the eric-wieser/tidy-ordinal-power branch November 9, 2023 04:59
@kmill
Copy link
Contributor

kmill commented Nov 9, 2023

(Unfortunately this will cause merge conflicts with the fixes for #2220... Oh well)

grunweg pushed a commit that referenced this pull request Dec 15, 2023
These were caused by a bad notation precedence in mathlib3, where the local version of `^` was given precedence 0. We're not using the local notation at all in Mathlib4 (partly because it was broken, which this PR fixes).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elaboration of ^ shouldn't try to put the arguments in the same type
3 participants