Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: @[eqns] attribute to override equation lemmas #3024

Closed
wants to merge 8 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Mar 21, 2023

This is to help with #2960 and work around leanprover/lean4#2042.

Ideally we would inspect the function to find that it was declared as | i, j => A j i and generate transpose_apply, but that's not something I know how to do.


Open in Gitpod

Mathlib/Tactic/Eqns.lean Outdated Show resolved Hide resolved
Mathlib/Tactic/Eqns.lean Outdated Show resolved Hide resolved
@gebner
Copy link
Member

gebner commented Apr 11, 2023

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Apr 11, 2023
bors bot pushed a commit that referenced this pull request Apr 11, 2023
This is to help with #2960 and work around leanprover/lean4#2042.

Ideally we would inspect the function to find that it was declared as `| i, j => A j i` and generate `transpose_apply`, but that's not something I know how to do.



Co-authored-by: Scott Morrison <[email protected]>
Co-authored-by: Jeremy Tan Jie Rui <[email protected]>
@bors
Copy link

bors bot commented Apr 11, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: @[eqns] attribute to override equation lemmas [Merged by Bors] - feat: @[eqns] attribute to override equation lemmas Apr 11, 2023
@bors bors bot closed this Apr 11, 2023
@bors bors bot deleted the eqn_lemmas branch April 11, 2023 18:55
eric-wieser added a commit that referenced this pull request Apr 12, 2023
This is to help with #2960 and work around leanprover/lean4#2042.

Ideally we would inspect the function to find that it was declared as `| i, j => A j i` and generate `transpose_apply`, but that's not something I know how to do.



Co-authored-by: Scott Morrison <[email protected]>
Co-authored-by: Jeremy Tan Jie Rui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants