Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: replace right_deriv by rightDeriv in lemma names #21076

Closed
wants to merge 1 commit into from

Conversation

RemyDegenne
Copy link
Contributor

@RemyDegenne RemyDegenne commented Jan 26, 2025

And similarly for left_deriv.

There is no leftDeriv or rightDeriv definition (they refer to a derivWithin in an interval) but they have a similar role in lemma names so should be written in the same way as definitions.


Open in Gitpod

@RemyDegenne RemyDegenne added the t-analysis Analysis (normed *, calculus) label Jan 26, 2025
Copy link

PR summary b2df5ca6b4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ leftDeriv_le_slope
+ leftDeriv_lt_slope
+ rightDeriv_le_slope
+ rightDeriv_lt_slope
+ slope_le_leftDeriv
+ slope_le_rightDeriv
+ slope_lt_leftDeriv
+ slope_lt_rightDeriv

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no leftDeriv or rightDeriv definition

Maybe they should be? x appears twice in derivWithin f (Ioi x) x, and that's usually taken to be the point at which it's worth making a function.

Anyway, this PR looks good, thanks!

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@sgouezel
Copy link
Contributor

bors r+
Thanks!

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 26, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 26, 2025
And similarly for `left_deriv`.

There is no `leftDeriv` or `rightDeriv` definition (they refer to a `derivWithin` in an interval) but they have a similar role in lemma names so should be written in the same way as definitions.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 26, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: replace right_deriv by rightDeriv in lemma names [Merged by Bors] - chore: replace right_deriv by rightDeriv in lemma names Jan 26, 2025
@mathlib-bors mathlib-bors bot closed this Jan 26, 2025
@mathlib-bors mathlib-bors bot deleted the RD_rename branch January 26, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants