Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Data/Nat/Choose/Sum): refined the statement of Finset.sum_antidiagonal_choose_add. #21022

Closed
wants to merge 1 commit into from

Conversation

FMLJohn
Copy link
Collaborator

@FMLJohn FMLJohn commented Jan 24, 2025


Open in Gitpod

In this pull request, we have refined the statement of the theorem Nat.sum_antidiagonal_choose_add. The original statement looked like:

theorem sum_antidiagonal_choose_add (d n : ℕ) :
    (∑ ij ∈ antidiagonal n, (d + ij.2).choose d) =
    (d + n).choose d + (d + n).choose (succ d) := ...

We change it to:

theorem sum_antidiagonal_choose_add (d n : ℕ) :
    (∑ ij ∈ antidiagonal n, (d + ij.2).choose d) =
    (d + n + 1).choose (d + 1) := ...

which looks much nicer.

@FMLJohn FMLJohn added t-combinatorics Combinatorics t-algebra Algebra (groups, rings, fields, etc) labels Jan 24, 2025
Copy link

PR summary cbd80b83cf

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clear improvement, thanks!

@FMLJohn FMLJohn requested a review from kbuzzard January 24, 2025 15:08
@b-mehta
Copy link
Contributor

b-mehta commented Jan 24, 2025

bors merge

@FMLJohn FMLJohn requested a review from jcommelin January 24, 2025 15:08
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 24, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 24, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 24, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/Nat/Choose/Sum): refined the statement of Finset.sum_antidiagonal_choose_add. [Merged by Bors] - chore(Data/Nat/Choose/Sum): refined the statement of Finset.sum_antidiagonal_choose_add. Jan 24, 2025
@mathlib-bors mathlib-bors bot closed this Jan 24, 2025
@mathlib-bors mathlib-bors bot deleted the refine_statement branch January 24, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-combinatorics Combinatorics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants