Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - doc(RingTheory/LaurentSeries): correct docstring #20990

Closed
wants to merge 4 commits into from

Conversation

AntoineChambert-Loir
Copy link
Collaborator

@AntoineChambert-Loir AntoineChambert-Loir commented Jan 23, 2025

Remove a superfluous backtick and remove .symm in a lemma of the docstring so that it can be made clickable.


Open in Gitpod

@AntoineChambert-Loir AntoineChambert-Loir changed the title chore(RingTheory/LaurentSeries): correct docstring doc(RingTheory/LaurentSeries): correct docstring Jan 23, 2025
Copy link

github-actions bot commented Jan 23, 2025

PR summary 5c8ca5c322

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jan 23, 2025
@faenuccio
Copy link
Collaborator

faenuccio commented Jan 23, 2025

The map powerSeries_equiv_subring goes from K[[X]] to the Subring of K((X)), so I am not sure about your second proposal of removing symm. Is that because you consider "being isomorphic to" as an equivalence relation that is not "ordered" and so two things are isomorphic as well as through an iso f and through f.symm?

@AntoineChambert-Loir
Copy link
Collaborator Author

Exactly. One could add that this is given by the inverse of the function, but I think that it is more helpful to have the website providing the link. (Another possibility is to have the docstring-to-html translator being able to recognize this,
but that's beyond my ability.)

@faenuccio
Copy link
Collaborator

Exactly. One could add that this is given by the inverse of the function, but I think that it is more helpful to have the website providing the link. (Another possibility is to have the docstring-to-html translator being able to recognize this, but that's beyond my ability.)

OK, I see your point, and actually quite like it. The docstring-to-html is also beyond my ability, so I think this PR is good as it is. Thanks!

@faenuccio
Copy link
Collaborator

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by faenuccio.

Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/RingTheory/LaurentSeries.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 23, 2025

✌️ AntoineChambert-Loir can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@AntoineChambert-Loir
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 23, 2025
Remove a superfluous backtick and remove `.symm` in a lemma of the docstring so that it can be made clickable.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 23, 2025

Build failed:

AntoineChambert-Loir and others added 2 commits January 23, 2025 18:18
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@AntoineChambert-Loir
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 23, 2025
Remove a superfluous backtick and remove `.symm` in a lemma of the docstring so that it can be made clickable.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 23, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title doc(RingTheory/LaurentSeries): correct docstring [Merged by Bors] - doc(RingTheory/LaurentSeries): correct docstring Jan 23, 2025
@mathlib-bors mathlib-bors bot closed this Jan 23, 2025
@mathlib-bors mathlib-bors bot deleted the ACL/Laurent_doc branch January 23, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated maintainer-merge t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants