Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: toAdditive to transfer MatcherInfo data #16026

Closed
wants to merge 1 commit into from

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Aug 21, 2024

so that printing the definitions shows match … with properly, and
meta code looking for matchers work.

Fixes an item on #1074

so that printing the definitions shows `match … with` properly, and
meta code looking for matchers work.

Fixes an item on #1074
Copy link

PR summary c1a5e8e4dd

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@grunweg grunweg added the t-meta Tactics, attributes or user commands label Aug 21, 2024
@grunweg
Copy link
Collaborator

grunweg commented Aug 21, 2024

Thanks for fixing this! I guess/hope that a few workarounds for this issue can be removed now (search for #1074, item (8)). Would you like to perform this clean-up also?

@nomeata
Copy link
Collaborator Author

nomeata commented Aug 21, 2024

Would you like to perform this clean-up also?

I wouldn’t mind if someone else will do that :-)

@grunweg
Copy link
Collaborator

grunweg commented Aug 21, 2024

Never mind, this actually fixes item 7 on the list: I don't see any obvious locations where this would simplify mathlib code.

@nomeata
Copy link
Collaborator Author

nomeata commented Aug 22, 2024

This is also needed after leanprover/lean4#4154 hits lean master, so if we merge it now then the nightly testing maintainers (@semorrison and @jcommelin) have less work with the next nightly.

@kim-em
Copy link
Contributor

kim-em commented Aug 23, 2024

Sold!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 23, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 23, 2024
so that printing the definitions shows `match … with` properly, and
meta code looking for matchers work.

Fixes an item on #1074
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: toAdditive to transfer MatcherInfo data [Merged by Bors] - feat: toAdditive to transfer MatcherInfo data Aug 23, 2024
@mathlib-bors mathlib-bors bot closed this Aug 23, 2024
@mathlib-bors mathlib-bors bot deleted the joachim/to-additive-match branch August 23, 2024 05:16
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
so that printing the definitions shows `match … with` properly, and
meta code looking for matchers work.

Fixes an item on #1074
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
so that printing the definitions shows `match … with` properly, and
meta code looking for matchers work.

Fixes an item on #1074
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
so that printing the definitions shows `match … with` properly, and
meta code looking for matchers work.

Fixes an item on #1074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants