Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Order): More simp lemmas #13338

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(Order): More simp lemmas #13338

wants to merge 1 commit into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented May 29, 2024 •
edited
Loading

These lemmas are needed in #13201

Open in Gitpod

@YaelDillies YaelDillies mentioned this pull request May 29, 2024
Closed
2 tasks
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 8, 2024
@YaelDillies
chore(Order): More simp lemmas
b7e1311 
These lemmas are needed #13201

protect new lemmas
@YaelDillies YaelDillies force-pushed the order_hom_mk_comp_mk branch from eb39d55 to b7e1311 Compare June 8, 2024 09:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 8, 2024

PR summary

Import changes

No significant changes to the import graph

Declarations diff

+ Antitone.iInf
+ Antitone.iSup
+ Antitone.sInf
+ Antitone.sSup
+ Monotone.iInf
+ Monotone.iSup
+ Monotone.sInf
+ Monotone.sSup
+ mk_comp_mk
- monotone_sInf_of_monotone
- monotone_sSup_of_monotone

You can run this locally as follows 
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 8, 2024
b-mehta
b-mehta reviewed Jun 29, 2024
View reviewed changes
Mathlib/Order/CompleteLattice.lean
theorem monotone_sSup_of_monotone {s : Set (α → β)} (m_s : ∀ f ∈ s, Monotone f) :
Monotone (sSup s) := fun _ _ h => iSup_mono fun f => m_s f f.2 h
#align monotone_Sup_of_monotone monotone_sSup_of_monotone
@[deprecated (since := "2024-05-29")] alias monotone_sSup_of_monotone := Monotone.sSup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since dot notation isn't actually useful here, I'm not sure deprecation is really deserved.

Copy link
Collaborator Author

@YaelDillies YaelDillies Jun 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is useful thanks to the new expected type dot notation. .sSup _ : Monotone _ should* elaborate to Monotone.sSup

*seems like there currently is a bug due to Monotone being defined as a forall. Not sure it's known

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not deprecate until the bug is reported then.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leanprover/lean4#4761

Mathlib/Order/Hom/Basic.lean Show resolved Hide resolved
@b-mehta
Copy link
Contributor

b-mehta commented Jul 14, 2024

bors d+

Awaiting the report of the bug above.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 14, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@b-mehta b-mehta added awaiting-author A reviewer has asked the author a question or requested changes and removed t-order Order theory labels Jul 14, 2024
@YaelDillies YaelDillies mentioned this pull request Jul 16, 2024
Closed
3 tasks
@YaelDillies
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jul 16, 2024
@YaelDillies
chore(Order): More simp lemmas (#13338)
dae74a5 
These lemmas are needed in #13201
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 16, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jul 16, 2024
@YaelDillies
chore(Order): More simp lemmas (#13338)
baa2175 
These lemmas are needed in #13201
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 16, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jul 16, 2024
@YaelDillies
chore(Order): More simp lemmas (#13338)
2422cb5 
These lemmas are needed in #13201
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Order): More simp lemmas [Merged by Bors] - chore(Order): More simp lemmas Jul 16, 2024
@mathlib-bors mathlib-bors bot closed this Jul 16, 2024
@mathlib-bors mathlib-bors bot deleted the order_hom_mk_comp_mk branch July 16, 2024 20:23
@adomani adomani mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-mehta b-mehta b-mehta left review comments

Assignees
No one assigned
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YaelDillies @b-mehta @kim-em @leanprover-community-mathlib4-bot