-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Eisenstein series uniform convergence #10377
Conversation
…mposition.lean Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…mposition.lean Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ergence.lean Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Mathlib/NumberTheory/ModularForms/EisensteinSeries/UniformConvergence.lean
Outdated
Show resolved
Hide resolved
Mathlib/NumberTheory/ModularForms/EisensteinSeries/UniformConvergence.lean
Outdated
Show resolved
Hide resolved
Mathlib/NumberTheory/ModularForms/EisensteinSeries/UniformConvergence.lean
Outdated
Show resolved
Hide resolved
Mathlib/NumberTheory/ModularForms/EisensteinSeries/UniformConvergence.lean
Outdated
Show resolved
Hide resolved
The main changes I made were:
|
I didn't know we had this norm on tuples, which I think really makes it much cleaner, so thank you! and thanks for the extra doc strings, I usually only add then to defs, but I this is a good idea going forward. The only thing I changed (other than some short golf) was the name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great – let's get this in!
Note to maintainers: the code is now kind of a joint effort, but Chris has carefully read the bits that I wrote, and vice versa, so I think we can count it all as being "reviewed".
maintainer merge
🚀 Pull request has been placed on the maintainer queue by loefflerd. |
Mathlib/NumberTheory/ModularForms/EisensteinSeries/UniformConvergence.lean
Show resolved
Hide resolved
Modulo Johan's comment LGTM, thanks! bors d+ |
✌️ CBirkbeck can now approve this pull request. To approve and merge a pull request, simply reply with |
…ergence.lean Co-authored-by: Johan Commelin <[email protected]>
bors r+ |
We show that the sum defining an Eisenstein Series converges locally uniformly. This is the basis for later proving that they are holomorphic (see #11013 ) and bounded at infinity (see #12456), which combine to show they are modular forms (see #12604). Co-authored-by: Chris Birkbeck <[email protected]> Co-authored-by: David Loeffler <[email protected]>
Pull request successfully merged into master. Build succeeded: |
We define the vertical strips that are needed for proving Eisenstein series are modular forms #10377 . We also add the definition of sqrt{-1} as an elements of the upper half plane. Note that this is no longer needed for the modular forms PRs but its good to have. Sorry about the typo in the PR name, its not my day! Co-authored-by: Chris Birkbeck <[email protected]>
Add `eq_zero_iff_eq_zero_of_mem_box` lemma needed for #10377
We also `summable_partition` (and the required `Set.sigmaEquiv`), needed for #10377. Co-authored-by: Chris Birkbeck <[email protected]>
We show that the sum defining an Eisenstein Series converges locally uniformly. This is the basis for later proving that they are holomorphic (see #11013 ) and bounded at infinity (see #12456), which combine to show they are modular forms (see #12604). Co-authored-by: Chris Birkbeck <[email protected]> Co-authored-by: David Loeffler <[email protected]>
We show that the sum defining an Eisenstein Series converges locally uniformly. This is the basis for later proving that they are holomorphic (see #11013 ) and bounded at infinity (see #12456), which combine to show they are modular forms (see #12604). Co-authored-by: Chris Birkbeck <[email protected]> Co-authored-by: David Loeffler <[email protected]>
We show that Eisenstein Series are MDifferentiable - [x] depends on: #10377 - [x] depends on: #11244 Co-authored-by: Chris Birkbeck <[email protected]>
We show that Eisenstein Series are MDifferentiable - [x] depends on: #10377 - [x] depends on: #11244 Co-authored-by: Chris Birkbeck <[email protected]>
We show that Eisenstein Series are MDifferentiable - [x] depends on: #10377 - [x] depends on: #11244 Co-authored-by: Chris Birkbeck <[email protected]>
We show that the sum defining an Eisenstein Series converges locally uniformly. This is the basis for later proving that they are holomorphic (see #11013 ) and bounded at infinity (see #12456), which combine to show they are modular forms (see #12604).