Address non-happy paths #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrute
force-pushed
the
info-improvements
branch
from
a91d602
to
5978638
Compare
|
I agree we should check Qt code before merging. I just haven't got around to running it yet. |
This was referenced Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the file_info messages don't have line and column. Sometimes a sync will get a "file unchanged" message or an error message. I wrote tests to cover these and fixed the Trio code.
I didn't fix or address the qt code. In particular, I made a change to the commands.py file (added a SyncResponse type (which has a message field). This might break something in the qt_server.
(This PR builds on my previous two.)