Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: commit lake-manifest.json #560

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

tydeu
Copy link
Collaborator

@tydeu tydeu commented Jan 25, 2024

This is needed for Lake & Reservoir to correctly identify the name of the package (since its name is std despite the repository being named std4). Without this, either Lake will fail to look up the package on require leanprover/std (because no leanprover/std package exists on Reservoir) or require leanprover/std4 will succeed but Lake will error when the package's name does not match std4. This is currently blocking leanprover/lean4#3174.

@tydeu
Copy link
Collaborator Author

tydeu commented Jan 25, 2024

awaiting-review

@github-actions github-actions bot added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Jan 25, 2024
@joehendrix
Copy link
Contributor

joehendrix commented Jan 25, 2024

I did an experiment on main and with this manifest I get the following messages when building with documentation on:

> lake build -R -Kdoc=on
error: missing manifest; use `lake update` to generate one
> lake update           
> lake build -R -Kdoc=on
[0/4] Building Std.Classes.BEq
..

Does leanprover/lean4#3174 fix the error message above? It seems like lake should regenerate the manifest automatically when reconfiguring since the requirements may change.

We may also want the manifest generated with -Kdoc=on if we include a manifest.

@tydeu tydeu force-pushed the commit-lake-manifest branch from d1d0a6e to 7e2cb87 Compare January 25, 2024 18:17
@tydeu
Copy link
Collaborator Author

tydeu commented Jan 25, 2024

@joehendrix Oops! Sorry, I forgot to include doc-gen4 in the manifest. With current Lake, you need to run lake -R -Kdoc=on update to generate a complete manifest for std4. leanprover/lean4#3174 will resolve this by automatically including all conditional dependencies in the manifest.

@joehendrix joehendrix merged commit 5368bbb into leanprover-community:main Jan 25, 2024
1 check passed
@tydeu tydeu deleted the commit-lake-manifest branch January 25, 2024 20:09
@digama0
Copy link
Member

digama0 commented Jan 27, 2024

I think we should remove the doc-gen4 pins from this manifest. Std does not build with doc-gen4, and having a doc-gen pin is misleading. See also the discussion on Zulip.

fgdorais pushed a commit to fgdorais/batteries that referenced this pull request Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review This PR is ready for review; the author thinks it is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants