feat: upstream addHaveSuggestion and addRewriteSuggestion #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-em
added
the
awaiting-review
kim-em
commented
Aug 9, 2023
kim-em
force-pushed
the
addRewriteSuggestion
branch
from
ed72df0 to
db96f32
Compare
fgdorais
approved these changes
Aug 10, 2023
|
WIP |
github-actions
bot
added
WIP
|
awaiting-review |
github-actions
bot
added
awaiting-review
kim-em
commented
Sep 4, 2023
leanprover-community-mathlib4-bot
added
the
merge-conflict
digama0
reviewed
Oct 24, 2023
leanprover-community-mathlib4-bot
removed
the
merge-conflict
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
digama0
reviewed
Jan 5, 2024
Std/Tactic/TryThis.lean
Outdated
| if prop then | ||
| `(tactic| have : $tstx := $estx) | ||
| else | ||
| `(tactic| let this : $tstx := $estx) |
There was a problem hiding this comment.
does this put this† in the output?
There was a problem hiding this comment.
Indeed, it does, and there's a FIXME in Mathlib's test/propose.lean about this.
There was a problem hiding this comment.
it should use $(mkIdent `this) instead
There was a problem hiding this comment.
Okay, I've fixed the behaviour of Mathlib's have? and observe? in leanprover-community/mathlib4#9454, and will modify this PR accordingly.
joehendrix
approved these changes
Jan 25, 2024
joehendrix
added
will-merge-soon
fgdorais
pushed a commit
to fgdorais/batteries
that referenced
this pull request
Feb 18, 2024
…-community#210) Co-authored-by: Mario Carneiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreams two more "Try this:" builders.