chore: port latest fixes from nightly-testing #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Scott Morrison <[email protected]>
|
Can I instead rebase |
|
That should be fine. The only important invariant is that (In particular, no bots interact with |
JLimperg
force-pushed
the
bump/v4.6.0
branch
2 times, most recently
from
eb8f6e3 to
7a0082b
Compare
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 24, 2024
This is a PR to `bump/v4.6.0`, incorporating the changes on `nightly-testing` up to `nightly-2024-01-22`. Note that for now this moves `aesop` to the `nightly-testing` branch. Once leanprover-community/aesop#97 lands we can move this back to `bump/v4.6.0`. This PR doesn't need to wait on that, however. Co-authored-by: Scott Morrison <[email protected]>
|
As discussed on Zulip, I rebased and force-pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are fixes on the
nightly-testingbranch, mostly due to @JLimperg. This PR is merging them into thebump/v4.6.0release ready for the end of the month.(@JLimperg, even though these are your changes, can I leave this PR to you to sanity check and merge?)