-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test that an executable importing Aesop works #182
Conversation
The extracted closed term here is:
and
so it is indexing into an empty array. I'm very certain that I have seen this issue on the core issue tracker before but I cannot find it anymore :(. The trivial fix is of course to disable the closed term extractor here. Alternatively we could fiddle with the code until this doesn't happen anymore or wait for the new code generator. |
#183 fixes the segfault by disabling extraction for Leaving this PR open for the regression test. |
This does add 1:23 minutes to the CI time, which I don't like. But I also don't like this breakage! |
@hargoniX Could you be looking for leanprover/lean4#5188? |
Yes! |
Rather than add to the CI time, let's do this daily in Mathlib, where we already have infrastructure for daily CI runs for expensive jobs. |
Currently, any executable importing
Aesop
will segfault on initialization.segfaults under this PR, which adds a minimal executable.
followed by the lldb commands
run
andbt
shows the stack trace:Even after fixing the underlying problem, we can't merge this as a regression test PR without adjusting the testDriver set up. We want to both run the executable, and build the
AesopTest
library, and as far as I can see this isn't currently possible.