chore: update for renamed fields in Subarray #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-christiansen
force-pushed
the
subarray-names
branch
from
becade7 to
eb851a9
Compare
|
Adaptation for leanprover/lean4#3851 and leanprover-community/batteries#733 |
|
@JLimperg I'm not entirely sure what the failing test for lists is testing - can you see if it is the test or the implementation that needs to be updated? |
|
I've fixed some of the tests. The others are fixed in #117; please merge the relevant parts of that PR. |
|
It looks like this was superseded by #123 - thanks for the help! |
|
Sorry, I should have looked at the open PRs! I'd made the fix locally when getting mathlib back up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.